From: Bjorn Helgaas <helgaas@kernel.org>
To: Ondrej Zary <linux@zary.sk>
Cc: rjw@rjwysocki.net, gottwald@igel.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org, mika.westerberg@linux.intel.com
Subject: Re: [PATCH] PCI: PM: Extend Elo i2 quirk to all systems using Continental Z2 board
Date: Thu, 8 Jun 2023 15:31:58 -0500 [thread overview]
Message-ID: <20230608203158.GA1213764@bhelgaas> (raw)
In-Reply-To: <20230519085853.1079-1-linux@zary.sk>
[+cc Stefan]
s|PCI: PM:|PCI/PM| in the subject to match history.
On Fri, May 19, 2023 at 10:58:53AM +0200, Ondrej Zary wrote:
> The quirk for Elo i2 is also needed by EloPOS E2/S2/H2 which uses the
> same Continental Z2 board. Change the quirk to match the board instead
> of system.
I would mention 92597f97a40b ("PCI/PM: Avoid putting Elo i2 PCIe Ports in
D3cold") here since it has more details that might be relevant.
Is there a problem report we can point to here? Oh, I see you chimed
in on https://bugzilla.kernel.org/show_bug.cgi?id=215715. Let's
include that link here, too.
This also needs a Signed-off-by tag; see
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.3#n363
Maybe also a stable tag since 92597f97a40b had one.
After we have the above tweaks, I plan to apply this unless somebody
objects.
Bjorn
> ---
> drivers/pci/pci.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 5ede93222bc1..c779eb4d7fb8 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2949,13 +2949,13 @@ static const struct dmi_system_id bridge_d3_blacklist[] = {
> {
> /*
> * Downstream device is not accessible after putting a root port
> - * into D3cold and back into D0 on Elo i2.
> + * into D3cold and back into D0 on Elo Continental Z2 board
> */
> - .ident = "Elo i2",
> + .ident = "Elo Continental Z2",
> .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Elo Touch Solutions"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Elo i2"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "RevB"),
> + DMI_MATCH(DMI_BOARD_VENDOR, "Elo Touch Solutions"),
> + DMI_MATCH(DMI_BOARD_NAME, "Geminilake"),
> + DMI_MATCH(DMI_BOARD_VERSION, "Continental Z2"),
> },
> },
> #endif
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-06-08 20:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 17:38 [PATCH] PCI: PM: Quirk bridge D3 on Elo i2 Rafael J. Wysocki
2022-03-31 21:57 ` Bjorn Helgaas
2022-04-01 11:34 ` Rafael J. Wysocki
2022-04-04 14:46 ` Rafael J. Wysocki
2022-04-08 19:53 ` Bjorn Helgaas
2022-04-09 13:35 ` Rafael J. Wysocki
2022-04-10 9:16 ` Thorsten Leemhuis
2022-04-11 11:35 ` Rafael J. Wysocki
2022-04-11 12:10 ` Thorsten Leemhuis
2022-04-11 16:22 ` Bjorn Helgaas
2022-05-26 22:12 ` Bjorn Helgaas
2022-05-27 18:55 ` Rafael J. Wysocki
2023-05-19 8:58 ` [PATCH] PCI: PM: Extend Elo i2 quirk to all systems using Continental Z2 board Ondrej Zary
2023-06-08 20:31 ` Bjorn Helgaas [this message]
2023-06-14 7:42 ` [PATCH] PCI/PM: " Ondrej Zary
2023-06-14 17:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608203158.GA1213764@bhelgaas \
--to=helgaas@kernel.org \
--cc=gottwald@igel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@zary.sk \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).