From: Sui Jingfeng <15330273260@189.cn>
To: Lucas Stach <l.stach@pengutronix.de>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
loongson-kernel@lists.loongnix.cn,
Sui Jingfeng <suijingfeng@loongson.cn>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH v9 1/9] drm/etnaviv: Add a dedicated function to register an irq handler
Date: Wed, 14 Jun 2023 10:47:37 +0800 [thread overview]
Message-ID: <20230614024745.865129-2-15330273260@189.cn> (raw)
In-Reply-To: <20230614024745.865129-1-15330273260@189.cn>
From: Sui Jingfeng <suijingfeng@loongson.cn>
Because getting IRQ from a device is platform-dependent, PCI devices have
different methods for getting an IRQ. This patch is a preparation patch to
extend the driver for the PCI device support.
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 32 +++++++++++++++++++--------
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index de8c9894967c..a03e81337d8f 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1817,6 +1817,27 @@ static const struct of_device_id etnaviv_gpu_match[] = {
};
MODULE_DEVICE_TABLE(of, etnaviv_gpu_match);
+static int etnaviv_gpu_register_irq(struct etnaviv_gpu *gpu, int irq)
+{
+ struct device *dev = gpu->dev;
+ int err;
+
+ if (irq < 0)
+ return irq;
+
+ err = devm_request_irq(dev, irq, irq_handler, 0, dev_name(dev), gpu);
+ if (err) {
+ dev_err(dev, "failed to request irq %u: %d\n", irq, err);
+ return err;
+ }
+
+ gpu->irq = irq;
+
+ dev_info(dev, "irq(%d) handler registered\n", irq);
+
+ return 0;
+}
+
static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -1837,16 +1858,9 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
return PTR_ERR(gpu->mmio);
/* Get Interrupt: */
- gpu->irq = platform_get_irq(pdev, 0);
- if (gpu->irq < 0)
- return gpu->irq;
-
- err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
- dev_name(gpu->dev), gpu);
- if (err) {
- dev_err(dev, "failed to request IRQ%u: %d\n", gpu->irq, err);
+ err = etnaviv_gpu_register_irq(gpu, platform_get_irq(pdev, 0));
+ if (err)
return err;
- }
/* Get Clocks: */
gpu->clk_reg = devm_clk_get_optional(&pdev->dev, "reg");
--
2.25.1
next prev parent reply other threads:[~2023-06-14 2:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 2:47 [PATCH v9 0/9] drm/etnaviv: Add pci device driver support Sui Jingfeng
2023-06-14 2:47 ` Sui Jingfeng [this message]
2023-06-14 2:47 ` [PATCH v9 2/9] drm/etnaviv: Add a dedicated function to get various clocks Sui Jingfeng
2023-06-14 2:47 ` [PATCH v9 3/9] drm/etnaviv: Add dedicated functions to create and destroy platform device Sui Jingfeng
2023-06-14 2:47 ` [PATCH v9 4/9] drm/etnaviv: Add helpers for private data construction and destruction Sui Jingfeng
2023-06-14 2:47 ` [PATCH v9 5/9] drm/etnaviv: Allow bypass component framework Sui Jingfeng
2023-06-14 2:47 ` [PATCH v9 6/9] drm/etnaviv: Add driver support for the PCI devices Sui Jingfeng
2023-06-14 2:47 ` [PATCH v9 7/9] drm/etnaviv: Add support for the dma coherent device Sui Jingfeng
2023-06-14 9:13 ` Sui Jingfeng
2023-06-14 2:47 ` [PATCH v9 8/9] drm/etnaviv: Add a dedicated function to create the virtual master Sui Jingfeng
2023-06-14 2:47 ` [PATCH v9 9/9] drm/etnaviv: Clean up etnaviv_pdev_probe() function Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614024745.865129-2-15330273260@189.cn \
--to=15330273260@189.cn \
--cc=bhelgaas@google.com \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=p.zabel@pengutronix.de \
--cc=suijingfeng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).