From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC31EB64DA for ; Thu, 15 Jun 2023 14:36:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244999AbjFOOg0 (ORCPT ); Thu, 15 Jun 2023 10:36:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241156AbjFOOgY (ORCPT ); Thu, 15 Jun 2023 10:36:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC10A194; Thu, 15 Jun 2023 07:36:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68E2961298; Thu, 15 Jun 2023 14:36:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B10CC433C8; Thu, 15 Jun 2023 14:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686839781; bh=j7fswNF00+3EsBKE9l3ZGPQpN/5xxxUoZx34TL5CkLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wJUePUXSGwFyZeIXTc/MCaXOpmi+1fQwp9quAdxPgCGFMgaGIGyuHot/RM4V9eUSg bRRuajr0ywJxzZyTWi2eh94EmsUitXvQ9RpBJaxUWdHeJWwkm0GryLE5dqXgxMFtnn kkFShesR42R6MG9PPdyUMHbNJJR5HLfYk9Kmbeeo= Date: Thu, 15 Jun 2023 16:36:19 +0200 From: Greg Kroah-Hartman To: Prashanth K Cc: Heikki Krogerus , AngeloGioacchino Del Regno , Matthias Brugger , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7] usb: common: usb-conn-gpio: Set last role to unknown before initial detection Message-ID: <2023061512-vowed-panther-38ed@gregkh> References: <1685544074-17337-1-git-send-email-quic_prashk@quicinc.com> <2023061547-staleness-camper-ae8a@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2023 at 07:52:32PM +0530, Prashanth K wrote: > > > On 15-06-23 03:00 pm, Greg Kroah-Hartman wrote: > > On Wed, Jun 14, 2023 at 12:14:08PM +0300, Heikki Krogerus wrote: > > > On Wed, May 31, 2023 at 08:11:14PM +0530, Prashanth K wrote: > > > > Currently if we bootup a device without cable connected, then > > > > usb-conn-gpio won't call set_role() since last_role is same as > > > > current role. This happens because during probe last_role gets > > > > initialised to zero. > > > > > > > > To avoid this, added a new constant in enum usb_role, last_role > > > > is set to USB_ROLE_UNKNOWN before performing initial detection. > > > > > > > > While at it, also handle default case for the usb_role switch > > > > in cdns3, intel-xhci-usb-role-switch & musb/jz4740 to avoid > > > > build warnings. > > > > > > > > Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver") > > > > Signed-off-by: Prashanth K > > > > Reviewed-by: AngeloGioacchino Del Regno > > > > --- > > > > v7: Added default case in musb/jz4740.c & intel-xhci-usb-role-switch.c to > > > > avoid build warnings. > > > > v6: Moved USB_ROLE_UNKNOWN towards the end of enum usb_role. > > > > v5: Update commit text to mention the changes made in cdns3 driver. > > > > v4: Added Reviewed-by tag. > > > > v3: Added a default case in drivers/usb/cdns3/core.c as pointed out by > > > > the test robot. > > > > v2: Added USB_ROLE_UNKNWON to enum usb_role. > > > > > > > > drivers/usb/cdns3/core.c | 2 ++ > > > > drivers/usb/common/usb-conn-gpio.c | 3 +++ > > > > drivers/usb/musb/jz4740.c | 2 ++ > > > > drivers/usb/roles/intel-xhci-usb-role-switch.c | 2 ++ > > > > include/linux/usb/role.h | 1 + > > > > 5 files changed, 10 insertions(+) > > > > > > Just to be clear to everybody, that USB_ROLE_UNKNOWN is not handled in > > > drivers/usb/roles/class.c, so this patch is broken. > > > > > > But the whole approach is wrong. That USB_ROLE_UNKNOWN is clearly a > > > flag where the other values in enum usb_role are actual switch states. > > > So it does not belong there. > > > > > > In general, adding globals states like that just in order to work > > > around issues in single drivers is never a good idea IMO. > > > > Ok, let me go revert this from my tree, thanks for the review. > > > > greg k-h > > In that case, can I resubmit v1 of this patch again, where I have used a > macro in usb-conn-gpio driver ? something like this. > > @@ -27,6 +27,8 @@ > #define USB_CONN_IRQF \ > (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT) > > +#define USB_ROLE_UNKNOWN (USB_ROLE_NONE -1) Are you referencing an existing enum here and assuming it is a specific value? For obvious reasons, that can never work :) thanks, greg k-h