From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 899CDEB64DB for ; Tue, 20 Jun 2023 20:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjFTUTX (ORCPT ); Tue, 20 Jun 2023 16:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbjFTUTT (ORCPT ); Tue, 20 Jun 2023 16:19:19 -0400 Received: from out-26.mta0.migadu.com (out-26.mta0.migadu.com [91.218.175.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D2E519A4 for ; Tue, 20 Jun 2023 13:18:59 -0700 (PDT) Date: Tue, 20 Jun 2023 16:18:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687292337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AknCkCooyVujKThdxC1FM7ZvENiuN9/CmEk5IHQ7iJc=; b=XuzztPfVVe+3n5nJEOjm27aqlllgXuZQ6rVKnaNP1qE0QAgMdGx6B41jDrtlCUaSZVvcwB aFXG7iOPoRS+k3iuIDq6aCVJVdfwEIwxm8O1jeyxNx8BlQuDXJKsTMlQrOrb4Uy0Osm8So ZIKImGyM50seypVLOxcay429rYAWiDE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Dave Hansen Cc: Andy Lutomirski , Mark Rutland , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, "linux-bcachefs@vger.kernel.org" , Kent Overstreet , Andrew Morton , Uladzislau Rezki , "hch@infradead.org" , linux-mm@kvack.org, Kees Cook , the arch/x86 maintainers Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: <20230620201851.qrcabl327mrofygb@moria.home.lan> References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> <20230619104717.3jvy77y3quou46u3@moria.home.lan> <20230619191740.2qmlza3inwycljih@moria.home.lan> <5ef2246b-9fe5-4206-acf0-0ce1f4469e6c@app.fastmail.com> <20230620180839.oodfav5cz234pph7@moria.home.lan> <37d2378e-72de-e474-5e25-656b691384ba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37d2378e-72de-e474-5e25-656b691384ba@intel.com> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2023 at 11:48:26AM -0700, Dave Hansen wrote: > >> No, I'm saying your concerns are baseless and too vague to > >> address. > > If you don't address them, the NAK will stand forever, or at least > > until a different group of people take over x86 maintainership. > > That's fine with me. > > I've got a specific concern: I don't see vmalloc_exec() used in this > series anywhere. I also don't see any of the actual assembly that's > being generated, or the glue code that's calling into the generated > assembly. > > I grepped around a bit in your git trees, but I also couldn't find it in > there. Any chance you could help a guy out and point us to some of the > specifics of this new, tiny JIT? vmalloc_exec() has already been dropped from the patchset - I'll switch to the new jit allocator when that's available and doing sub-page allocations. I can however point you at the code that generates the unpack functions: https://evilpiepirate.org/git/bcachefs.git/tree/fs/bcachefs/bkey.c#n727 > >> Andy, I replied explaining the difference between text_poke() and > >> text_poke_sync(). It's clear you have no idea what you're talking about, > >> so I'm not going to be wasting my time on further communications with > >> you. > > One more specific concern: This comment made me very uncomfortable and > it read to me very much like a personal attack, something which is > contrary to our code of conduct. It's not; I prefer to be direct than passive aggressive, and if I have to bow out of a discussion that isn't going anywhere I feel I owe an explanation of _why_. Too much conflict avoidance means things don't get resolved. And Andy and I are talking on IRC now, so things are proceeding in a better direction.