From: Ravi Bangoria <ravi.bangoria@amd.com>
To: <acme@kernel.org>
Cc: <ravi.bangoria@amd.com>, <peterz@infradead.org>,
<irogers@google.com>, <jolsa@kernel.org>, <namhyung@kernel.org>,
<adrian.hunter@intel.com>, <linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sandipan.das@amd.com>,
<ananth.narayan@amd.com>, <santosh.shukla@amd.com>
Subject: [PATCH] perf evsel amd: Fix IBS error message
Date: Wed, 21 Jun 2023 11:53:59 +0530 [thread overview]
Message-ID: <20230621062359.201-1-ravi.bangoria@amd.com> (raw)
In-Reply-To: <3b0abd4a-6450-c282-65ff-ec0c7df67b03@amd.com>
AMD IBS can do per-process profiling[1] and is no longer restricted to
per-cpu or systemwide only. Remove stale error message.
Before:
$ sudo ./perf record -e "{ibs_op//,ibs_op//}" -C 0
Error:
AMD IBS may only be available in system-wide/per-cpu mode.
Try using -a, or -C and workload affinity
After:
$ sudo ./perf record -e "{ibs_op//,ibs_op//}" -C 0
Error:
The sys_perf_event_open() syscall returned with 22 (Invalid
argument) for event (ibs_op//).
/bin/dmesg | grep -i perf may provide additional information.
[1] https://git.kernel.org/torvalds/c/30093056f7b2
Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
---
tools/perf/util/evsel.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 356c07f03be6..65b0b70830f0 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3092,14 +3092,10 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
return scnprintf(msg, size,
"Invalid event (%s) in per-thread mode, enable system wide with '-a'.",
evsel__name(evsel));
- if (is_amd(arch, cpuid)) {
- if (is_amd_ibs(evsel)) {
- if (evsel->core.attr.exclude_kernel)
- return scnprintf(msg, size,
+ if (is_amd(arch, cpuid) && is_amd_ibs(evsel)) {
+ if (evsel->core.attr.exclude_kernel) {
+ return scnprintf(msg, size,
"AMD IBS can't exclude kernel events. Try running at a higher privilege level.");
- if (!evsel->core.system_wide)
- return scnprintf(msg, size,
- "AMD IBS may only be available in system-wide/per-cpu mode. Try using -a, or -C and workload affinity");
}
}
--
2.41.0
next prev parent reply other threads:[~2023-06-21 6:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 9:16 [PATCH] perf/amd: Prevent grouping of IBS events Ravi Bangoria
2023-06-20 16:44 ` Ian Rogers
2023-06-21 3:27 ` Ravi Bangoria
2023-06-21 6:23 ` Ravi Bangoria [this message]
2023-06-21 22:33 ` [PATCH] perf evsel amd: Fix IBS error message Namhyung Kim
2023-06-22 5:27 ` Ravi Bangoria
2023-06-22 5:38 ` Namhyung Kim
2023-06-21 22:50 ` [PATCH] perf/amd: Prevent grouping of IBS events Namhyung Kim
2023-06-22 3:30 ` Ravi Bangoria
2023-06-22 5:09 ` Ian Rogers
2023-06-22 5:39 ` Ravi Bangoria
2023-06-22 5:44 ` Ian Rogers
2023-06-22 5:49 ` Ravi Bangoria
2023-07-10 8:37 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621062359.201-1-ravi.bangoria@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ananth.narayan@amd.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).