From: "Krzysztof Wilczyński" <kw@linux.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
thierry.reding@gmail.com, jonathanh@nvidia.com,
Sergey.Semin@baikalelectronics.ru, linux-pci@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V4] Revert "PCI: tegra194: Enable support for 256 Byte payload"
Date: Fri, 4 Aug 2023 03:50:31 +0900 [thread overview]
Message-ID: <20230803185031.GA3849329@rocinante> (raw)
In-Reply-To: <55e8a27b-580f-8b33-f069-a05cc5322cbb@nvidia.com>
Hello!
[...]
> > > After commit 4fb8e46c1bc4 ("PCI: tegra194: Enable support for 256 Byte
> > > payload"), we set MPS=256 for tegra194 Root Ports.
> > >
> > > By default (CONFIG_PCIE_BUS_DEFAULT set and no "pci=pcie_bus_*"
> > > parameter), Linux configures the MPS of every device to match the
> > > upstream bridge, which is impossible if the Root Port has MPS=256
> > > and a device only supports MPS=128.
> >
> > Thanks for pointing out that I broke this log by omitting the mention
> > of a switch. Is the rewording below better? If so, Krzysztof can
> > amend the commit.
> Yes. The below rewording looks good.
Updated commit at:
https://git.kernel.org/pci/pci/c/ebfde1584d9f
Thank you everyone!
Krzysztof
next prev parent reply other threads:[~2023-08-03 18:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 9:36 [PATCH V1] Revert "PCI: tegra194: Enable support for 256 Byte payload" Vidya Sagar
2023-06-08 16:33 ` Bjorn Helgaas
2023-06-09 2:23 ` Vidya Sagar
2023-06-14 10:39 ` Jon Hunter
2023-06-19 1:42 ` [PATCH V2] " Vidya Sagar
2023-06-19 3:42 ` kernel test robot
2023-06-19 10:26 ` [PATCH V3] " Vidya Sagar
2023-06-27 10:48 ` Krzysztof Wilczyński
2023-07-13 21:39 ` Bjorn Helgaas
2023-07-18 2:33 ` Vidya Sagar
2023-07-18 11:09 ` Bjorn Helgaas
2023-07-19 11:01 ` Vidya Sagar
2023-07-19 14:57 ` Bjorn Helgaas
2023-07-18 2:52 ` [PATCH V4] " Vidya Sagar
2023-07-21 8:23 ` Jon Hunter
2023-07-21 10:35 ` Bjorn Helgaas
2023-07-28 12:44 ` Jon Hunter
2023-08-01 20:40 ` Bjorn Helgaas
2023-08-03 9:19 ` Vidya Sagar
2023-08-03 18:50 ` Krzysztof Wilczyński [this message]
2023-07-25 7:51 ` [PATCH V1] " Manivannan Sadhasivam
2023-07-25 8:19 ` Vidya Sagar
2023-07-25 8:30 ` Manivannan Sadhasivam
2023-07-25 9:21 ` Vidya Sagar
2023-07-25 10:03 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803185031.GA3849329@rocinante \
--to=kw@linux.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).