From: Byungchul Park <byungchul@sk.com>
To: Nadav Amit <namit@vmware.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"kernel_team@skhynix.com" <kernel_team@skhynix.com>,
Andrew Morton <akpm@linux-foundation.org>,
"ying.huang@intel.com" <ying.huang@intel.com>,
"xhao@linux.alibaba.com" <xhao@linux.alibaba.com>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [RFC 2/2] mm: Defer TLB flush by keeping both src and dst folios at migration
Date: Mon, 7 Aug 2023 14:05:31 +0900 [thread overview]
Message-ID: <20230807050531.GB49200@system.software.com> (raw)
In-Reply-To: <7023C1AF-6C9B-4544-8EC4-0BB790C1E338@vmware.com>
On Fri, Aug 04, 2023 at 05:32:30PM +0000, Nadav Amit wrote:
> The patch in its current form, I am afraid, is very very hard to review.
> It is way too big and is missing comments. Having CONFIG_MIGRC makes no
> sense (I guess it is intended to be a “chicken-bit”). Variable and
> function names are not informative. The memory barriers are handle
> improperly (please check again the smp_mb__after_atomic() rules).
I checked it. I found what I was wrong at. Thank you for pointing it out.
I will fix it from the next spin.
Byungchul
next prev parent reply other threads:[~2023-08-07 5:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 6:18 [RFC 0/2] Reduce TLB flushes under some specific conditions Byungchul Park
2023-08-04 6:18 ` [RFC 1/2] mm/rmap: Recognize non-writable TLB entries during TLB batch flush Byungchul Park
2023-08-04 6:18 ` [RFC 2/2] mm: Defer TLB flush by keeping both src and dst folios at migration Byungchul Park
2023-08-04 16:08 ` Zi Yan
2023-08-07 0:43 ` Byungchul Park
2023-08-04 17:32 ` Nadav Amit
2023-08-07 1:42 ` Byungchul Park
2023-08-07 5:05 ` Byungchul Park [this message]
2023-08-15 1:27 ` Huang, Ying
2023-08-16 0:13 ` Byungchul Park
2023-08-16 1:01 ` Huang, Ying
2023-08-16 2:40 ` Byungchul Park
2023-08-21 1:28 ` Byungchul Park
2023-08-21 2:51 ` Huang, Ying
2023-08-17 8:16 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807050531.GB49200@system.software.com \
--to=byungchul@sk.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kernel_team@skhynix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=willy@infradead.org \
--cc=xhao@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).