From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Maxime Ripard <mripard@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] drivers: base: Add tests showing devm handling inconsistencies
Date: Sat, 12 Aug 2023 13:07:10 +0200 [thread overview]
Message-ID: <2023081248-uselessly-reckless-1963@gregkh> (raw)
In-Reply-To: <ckldghyavb6fj2mxfcw5spsr3v2rlyj2br64tnvwl5waz3i6id@zbxu7ipjtlwd>
On Mon, Aug 07, 2023 at 08:54:08AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Fri, Aug 04, 2023 at 05:01:50PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Jul 31, 2023 at 09:28:47AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Jul 31, 2023 at 08:34:03AM +0200, Maxime Ripard wrote:
> > > > On Thu, Jul 20, 2023 at 02:45:06PM +0200, Maxime Ripard wrote:
> > > > > Hi,
> > > > >
> > > > > This follows the discussion here:
> > > > > https://lore.kernel.org/linux-kselftest/20230324123157.bbwvfq4gsxnlnfwb@houat/
> > > > >
> > > > > This shows a couple of inconsistencies with regard to how device-managed
> > > > > resources are cleaned up. Basically, devm resources will only be cleaned up
> > > > > if the device is attached to a bus and bound to a driver. Failing any of
> > > > > these cases, a call to device_unregister will not end up in the devm
> > > > > resources being released.
> > > > >
> > > > > We had to work around it in DRM to provide helpers to create a device for
> > > > > kunit tests, but the current discussion around creating similar, generic,
> > > > > helpers for kunit resumed interest in fixing this.
> > > > >
> > > > > This can be tested using the command:
> > > > > ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/base/test/
> > > > >
> > > > > I added the fix David suggested back in that discussion which does fix
> > > > > the tests. The SoB is missing, since David didn't provide it back then.
> > > > >
> > > > > Let me know what you think,
> > > > > Maxime
> > > > >
> > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > > >
> > > > Ping?
> > >
> > > It's in my review queue, still trying to catch up...
> >
> > I didn't make it here this week, sorry.
>
> np, I just don't want that patch to disappear into the ether :)
>
> > I kind of worry about encoding the current "odd" functionality in a
> > test as being the correct thing, but will look at it closer next week.
>
> I don't think I'm doing that? The tests we've added are all how we think
> it should behave, the broken ones being skipped to avoid any failures.
>
> The last patch drops the kunit_skip() to make sure that it's tested
> going forward.
>
> So we shouldn't encode the odd behaviour anywhere in this series, unless
> I got you wrong?
No you are correct, I was mis-remembering things.
This looks good, thanks for sticking with it, all now applied to my
tree.
greg k-h
prev parent reply other threads:[~2023-08-12 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 12:45 [PATCH v3 0/3] drivers: base: Add tests showing devm handling inconsistencies Maxime Ripard
2023-07-20 12:45 ` [PATCH v3 1/3] drivers: base: Add basic devm tests for root devices Maxime Ripard
2023-07-20 12:45 ` [PATCH v3 2/3] drivers: base: Add basic devm tests for platform devices Maxime Ripard
2023-07-20 12:45 ` [PATCH v3 3/3] drivers: base: Free devm resources when unregistering a device Maxime Ripard
2023-07-31 6:34 ` [PATCH v3 0/3] drivers: base: Add tests showing devm handling inconsistencies Maxime Ripard
2023-07-31 7:28 ` Greg Kroah-Hartman
2023-08-04 15:01 ` Greg Kroah-Hartman
2023-08-07 6:54 ` Maxime Ripard
2023-08-12 11:07 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081248-uselessly-reckless-1963@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).