From: Will Deacon <will@kernel.org>
To: Gowthami Thiagarajan <gthiagarajan@marvell.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
George Cherian <gcherian@marvell.com>,
Linu Cherian <lcherian@marvell.com>
Subject: Re: [PATCH 3/6] perf/marvell : Odyssey LLC-TAD performance monitor support
Date: Tue, 15 Aug 2023 10:58:53 +0100 [thread overview]
Message-ID: <20230815095852.GB11083@willie-the-truck> (raw)
In-Reply-To: <SN1PR18MB21262B71F310B0AF33C2D2EFDB11A@SN1PR18MB2126.namprd18.prod.outlook.com>
On Sat, Aug 12, 2023 at 01:51:00PM +0000, Gowthami Thiagarajan wrote:
> > > +static int tad_pmu_probe(struct platform_device *pdev)
> > > +{
> > > + struct device *dev = &pdev->dev;
> > > + struct tad_region *regions;
> > > + struct tad_pmu *tad_pmu;
> > > + struct resource *res;
> > > + u32 tad_pmu_page_size;
> > > + u32 tad_page_size;
> > > + u32 tad_cnt;
> > > + int i, ret;
> > > + char *name;
> > > +
> > > + tad_pmu = devm_kzalloc(&pdev->dev, sizeof(*tad_pmu), GFP_KERNEL);
> > > + if (!tad_pmu)
> > > + return -ENOMEM;
> > > +
> > > + platform_set_drvdata(pdev, tad_pmu);
> > > +
> > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > + if (!res) {
> > > + dev_err(&pdev->dev, "Mem resource not found\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + ret = device_property_read_u32(dev, "marvell,tad-page-size", &tad_page_size);
> > > + if (ret) {
> > > + dev_err(&pdev->dev, "Can't find tad-page-size property\n");
> > > + return ret;
> > > + }
> > > +
> > > + ret = device_property_read_u32(dev, "marvell,tad-pmu-page-size",
> > > + &tad_pmu_page_size);
> > > + if (ret) {
> > > + dev_err(&pdev->dev, "Can't find tad-pmu-page-size property\n");
> > > + return ret;
> > > + }
> >
> > Why do you think these properties are necessary?
> >
> > These should almost certainly be provided by IO resources, and shouldn't need a
> > custom property.
>
> IO resources don't provide all the information in this case. Need to vary these values
> at different boot times. So, kept these custom properties.
Please can you be a bit more specific here? Which information is not
provided?
Will
next prev parent reply other threads:[~2023-08-15 10:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 12:03 [PATCH 0/6] Marvell Odyssey uncore performance monitor support Gowthami Thiagarajan
2023-06-30 12:03 ` [PATCH 1/6] perf/marvell: Marvell PEM " Gowthami Thiagarajan
2023-07-28 15:01 ` Mark Rutland
2023-08-12 3:43 ` [EXT] " Gowthami Thiagarajan
2023-06-30 12:03 ` [PATCH 2/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell PEM pmu Gowthami Thiagarajan
2023-07-02 9:25 ` Krzysztof Kozlowski
2023-07-28 15:23 ` Mark Rutland
2023-06-30 12:03 ` [PATCH 3/6] perf/marvell : Odyssey LLC-TAD performance monitor support Gowthami Thiagarajan
2023-07-28 15:38 ` Mark Rutland
2023-08-12 13:51 ` Gowthami Thiagarajan
2023-08-15 9:58 ` Will Deacon [this message]
2023-08-15 13:24 ` Mark Rutland
2023-08-17 13:26 ` [EXT] " Gowthami Thiagarajan
2023-06-30 12:03 ` [PATCH 4/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell Odyssey LLC-TAD pmu Gowthami Thiagarajan
2023-07-02 9:26 ` Krzysztof Kozlowski
2023-08-12 3:33 ` [EXT] " Gowthami Thiagarajan
2023-06-30 12:03 ` [PATCH 5/6] perf/marvell: Odyssey DDR Performance monitor support Gowthami Thiagarajan
2023-06-30 12:03 ` [PATCH 6/6] dt-bindings: Add YAML schemas for Marvell Odyssey DDR PMU Gowthami Thiagarajan
2023-07-02 9:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815095852.GB11083@willie-the-truck \
--to=will@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=gcherian@marvell.com \
--cc=gthiagarajan@marvell.com \
--cc=lcherian@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).