From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CFAEC83F11 for ; Sun, 27 Aug 2023 12:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbjH0MKu (ORCPT ); Sun, 27 Aug 2023 08:10:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjH0MKh (ORCPT ); Sun, 27 Aug 2023 08:10:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9CAE130; Sun, 27 Aug 2023 05:10:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7751B60F0F; Sun, 27 Aug 2023 12:10:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84B0DC433C7; Sun, 27 Aug 2023 12:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693138233; bh=WMzxN+/vPzfmnWAACf8mcof6OpZORi1WlHwqzQDLUrk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jCAZep4DsRDmbmzerSlURVj5dx6DHazJVvmof31F0VAjS3U6WGGomC14azfCjxn73 7aqr07Ia/1W6K0EMqWSRGkgQYSs0rWRWfeFhjKG1w1XQsqwOZw0THjcQEWQdijPQ1c N0qUJOtf0V61x/PXv0rfbNheIhOOuQJ6Sn96EPpUHplPiJLJv/GukG3b3zgFsE89sf g7e0Lm8SQZfjHzyFT7sw2jjHy+1uQhfbB94ST/x6KxHj8wbweG9Il6CrhluyYf5xHU lFFVTi5nDVGKeegzZXqO2Rl5QBFG8ZjktDtJbkG8mAP4rdjAGMb+6ny6V+hB4C7nyb V0Gt5YLkbNCTg== Date: Sun, 27 Aug 2023 13:10:28 +0100 From: Conor Dooley To: Krzysztof Kozlowski Cc: Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rohit Agarwal , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible Message-ID: <20230827-eggshell-rift-94f423e74dab@spud> References: <20230827085351.21932-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Y5ooK+v/FYTMRcoa" Content-Disposition: inline In-Reply-To: <20230827085351.21932-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Y5ooK+v/FYTMRcoa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 27, 2023 at 10:53:51AM +0200, Krzysztof Kozlowski wrote: > Commit c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC") adding > SDX65 was not ever tested and is clearly bogus. The qcom,sdx65-pcie-ep > compatible is followed by fallback in DTS and there is no driver > matching by this compatible. Driver matches by its fallback > qcom,sdx55-pcie-ep. This fixes also dtbs_check warnings like: >=20 > qcom-sdx65-mtp.dtb: pcie-ep@1c00000: compatible: ['qcom,sdx65-pcie-ep',= 'qcom,sdx55-pcie-ep'] is too long >=20 > Fixes: c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC") > Cc: > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Thanks, Conor. > --- > .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Do= cumentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index 811112255d7d..c94b49498f69 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -11,10 +11,13 @@ maintainers: > =20 > properties: > compatible: > - enum: > - - qcom,sdx55-pcie-ep > - - qcom,sdx65-pcie-ep > - - qcom,sm8450-pcie-ep > + oneOf: > + - enum: > + - qcom,sdx55-pcie-ep > + - qcom,sm8450-pcie-ep > + - items: > + - const: qcom,sdx65-pcie-ep > + - const: qcom,sdx55-pcie-ep > =20 > reg: > items: > @@ -110,7 +113,6 @@ allOf: > contains: > enum: > - qcom,sdx55-pcie-ep > - - qcom,sdx65-pcie-ep > then: > properties: > clocks: > --=20 > 2.34.1 >=20 --Y5ooK+v/FYTMRcoa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZOs9NAAKCRB4tDGHoIJi 0iL6APsGucI4pCdyWDXNGs3In99cNJWvdrvhE7ev5q0DILG3NAEA+2q4eG9xiZCJ POmCuJO6gXOLawwxCu2gSWuTtCNA1w4= =pkml -----END PGP SIGNATURE----- --Y5ooK+v/FYTMRcoa--