From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0033C83F16 for ; Sat, 26 Aug 2023 20:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjHZUBI (ORCPT ); Sat, 26 Aug 2023 16:01:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbjHZUBD (ORCPT ); Sat, 26 Aug 2023 16:01:03 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 275081FCB; Sat, 26 Aug 2023 13:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693080053; x=1724616053; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kRCs66Y4BOmYyzMuS8/lzn0GhXveL6QMCWUqcBj9eTA=; b=E/1dSjzg+VwLkccYfieQjX8YeHcMAkACg8H/g8y7uLGvQnLlm5dOCeu6 y+Rp5KrVfYqa8HMIGmrgRURSlyytxOpePdfXSHtuIckljIf+CfFVtIsNF lWwcofJR1W0xxR9qcAsRK5lIDXymjzJgvmUMc6LmFSbAlscjjKnFXFC2E LTwruSks94lOnwLwA+egyKr9M3/Vyqecg1UaEy/IQXj4XiLKJzVY1zXYC c5Zeowtm9k7T2tpMYluil9CkIJrkn3ZHM7EtpxAj3pHy/gEKYzA91aJXT 6Yr8sMlrmwNN6jQexGn5ySsUXTstdN11jocv9zQH33EFT/J7stLKhONZf A==; X-IronPort-AV: E=McAfee;i="6600,9927,10814"; a="355228502" X-IronPort-AV: E=Sophos;i="6.02,203,1688454000"; d="scan'208";a="355228502" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2023 13:00:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10814"; a="772839527" X-IronPort-AV: E=Sophos;i="6.02,203,1688454000"; d="scan'208";a="772839527" Received: from lkp-server02.sh.intel.com (HELO daf8bb0a381d) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 26 Aug 2023 13:00:49 -0700 Received: from kbuild by daf8bb0a381d with local (Exim 4.96) (envelope-from ) id 1qZzSi-00052F-3D; Sat, 26 Aug 2023 20:00:48 +0000 Date: Sun, 27 Aug 2023 04:00:35 +0800 From: kernel test robot To: Christophe JAILLET , rrameshbabu@nvidia.com, jikos@kernel.org, benjamin.tissoires@redhat.com Cc: oe-kbuild-all@lists.linux.dev, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: Re: [PATCH 3/3] HID: nvidia-shield: Introduce thunderstrike_destroy() Message-ID: <202308270307.EDe7t62T-lkp@intel.com> References: <4c9a8c7f6b4eb879dd7ef4d44bb6a80b3f126d25.1693070958.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c9a8c7f6b4eb879dd7ef4d44bb6a80b3f126d25.1693070958.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, kernel test robot noticed the following build warnings: [auto build test WARNING on linux-next/master] [cannot apply to linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/HID-nvidia-shield-Fix-a-missing-led_classdev_unregister-in-the-probe-error-handling-path/20230827-014602 base: linux-next/master patch link: https://lore.kernel.org/r/4c9a8c7f6b4eb879dd7ef4d44bb6a80b3f126d25.1693070958.git.christophe.jaillet%40wanadoo.fr patch subject: [PATCH 3/3] HID: nvidia-shield: Introduce thunderstrike_destroy() config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20230827/202308270307.EDe7t62T-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230827/202308270307.EDe7t62T-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308270307.EDe7t62T-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/hid/hid-nvidia-shield.c: In function 'shield_probe': >> drivers/hid/hid-nvidia-shield.c:1046:31: warning: variable 'ts' set but not used [-Wunused-but-set-variable] 1046 | struct thunderstrike *ts; | ^~ vim +/ts +1046 drivers/hid/hid-nvidia-shield.c 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1042 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1043 static int shield_probe(struct hid_device *hdev, const struct hid_device_id *id) 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1044 { 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1045 struct shield_device *shield_dev = NULL; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 @1046 struct thunderstrike *ts; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1047 int ret; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1048 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1049 ret = hid_parse(hdev); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1050 if (ret) { 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1051 hid_err(hdev, "Parse failed\n"); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1052 return ret; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1053 } 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1054 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1055 switch (id->product) { 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1056 case USB_DEVICE_ID_NVIDIA_THUNDERSTRIKE_CONTROLLER: 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1057 shield_dev = thunderstrike_create(hdev); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1058 break; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1059 } 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1060 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1061 if (unlikely(!shield_dev)) { 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1062 hid_err(hdev, "Failed to identify SHIELD device\n"); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1063 return -ENODEV; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1064 } 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1065 if (IS_ERR(shield_dev)) { 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1066 hid_err(hdev, "Failed to create SHIELD device\n"); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1067 return PTR_ERR(shield_dev); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1068 } 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1069 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1070 ts = container_of(shield_dev, struct thunderstrike, base); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1071 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1072 ret = hid_hw_start(hdev, HID_CONNECT_HIDINPUT); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1073 if (ret) { 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1074 hid_err(hdev, "Failed to start HID device\n"); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1075 goto err_haptics; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1076 } 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1077 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1078 ret = hid_hw_open(hdev); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1079 if (ret) { 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1080 hid_err(hdev, "Failed to open HID device\n"); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1081 goto err_stop; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1082 } 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1083 3ab196f882377ed Rahul Rameshbabu 2023-08-07 1084 thunderstrike_device_init_info(shield_dev); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1085 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1086 return ret; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1087 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1088 err_stop: 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1089 hid_hw_stop(hdev); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1090 err_haptics: 2cc4637842495c6 Christophe JAILLET 2023-08-26 1091 thunderstrike_destroy(hdev); 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1092 return ret; 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1093 } 09308562d4afb1a Rahul Rameshbabu 2023-06-08 1094 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki