From: Michal Kubecek <mkubecek@suse.cz>
To: Jijie Shao <shaojijie@huawei.com>
Cc: mkubeck@suse.cz, yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com,
liuyonglong@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH ethtool] hns3: add support dump registers for hns3 driver
Date: Mon, 28 Aug 2023 01:20:08 +0200 [thread overview]
Message-ID: <20230827232008.tjcuolelsdhh7o44@lion.mk-sys.cz> (raw)
In-Reply-To: <20230818085611.2483909-1-shaojijie@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]
On Fri, Aug 18, 2023 at 04:56:11PM +0800, Jijie Shao wrote:
> Add support pretty printer for the registers of hns3 driver.
> This printer supports PF and VF, and is compatible with hns3
> drivers of earlier versions.
>
> Sample output:
>
> $ ethtool -d eth1
> [cmdq_regs]
> comm_nic_csq_baseaddr_l : 0x48168000
> comm_nic_csq_baseaddr_h : 0x00000000
> comm_nic_csq_depth : 0x00000080
> comm_nic_csq_tail : 0x00000050
> comm_nic_csq_head : 0x00000050
> comm_nic_crq_baseaddr_l : 0x48170000
> comm_nic_crq_baseaddr_h : 0x00000000
> comm_nic_crq_depth : 0x00000080
> comm_nic_crq_tail : 0x00000000
> comm_nic_crq_head : 0x00000000
> comm_vector0_cmdq_src : 0x00000000
> comm_cmdq_intr_sts : 0x00000000
> comm_cmdq_intr_en : 0x00000002
> comm_cmdq_intr_gen : 0x00000000
> [common_regs]
> misc_vector_base : 0x00000001
> pf_other_int : 0x00000040
> misc_reset_sts : 0x00000000
> misc_vector_int_sts : 0x00000000
> global_reset : 0x00000000
> fun_rst_ing : 0x00000000
> gro_en : 0x00000001
> ...
>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
[...]
> --- /dev/null
> +++ b/hns3.c
[...]
> +#pragma pack(4)
> +struct hns3_reg_tlv {
> + u16 tag;
> + u16 len;
> +};
> +
> +struct hns3_reg_header {
> + u64 magic_number;
> + u8 is_vf;
> + u8 rsv[7];
> +};
> +
> +#pragma pack()
Could we please avoid these #pragma directives? AFAIK this is a Microsoft
extension, which, while implemented in gcc for compatibility reasons, is
not very common in linux world. To be honest, I had to search the web to
see what exactly does it do - and even after that, only checking the object
file with gdb revealed that it does not really do anything except weakening
the alignment of struct hns3_reg_header (as a whole). Given how the
structure is used in this file, the only practical effect would be
header_len in hns3_dump_regs() being 12 rather than 16 (on 64-bit
architectures).
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-08-27 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 8:56 [PATCH ethtool] hns3: add support dump registers for hns3 driver Jijie Shao
2023-08-23 3:15 ` Jijie Shao
2023-08-27 23:20 ` Michal Kubecek [this message]
2023-08-29 6:46 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230827232008.tjcuolelsdhh7o44@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=mkubeck@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).