From: "Luke D. Jones" <luke@ljones.dev>
To: hdegoede@redhat.com
Cc: corentin.chary@gmail.com, markgross@kernel.org,
linux-kernel@vger.kernel.org, "Luke D. Jones" <luke@ljones.dev>
Subject: [PATCH v5 0/1] platform/x86: asus-wmi: add support for ASUS screenpad
Date: Mon, 28 Aug 2023 11:23:57 +1200 [thread overview]
Message-ID: <20230827232358.80512-1-luke@ljones.dev> (raw)
Adds support for the screenpad(-plus) found on a few ASUS laptops that have a main 16:9 or 16:10
screen and a shorter screen below the main but above the keyboard.
The support consists of:
- On off control
- Setting brightness from 0-255
There are some small quirks with this device when considering only the raw WMI methods:
1. The Off method can only switch the device off
2. Changing the brightness turns the device back on
3. To turn the device back on the brightness must be > 1
4. When the device is off the brightness can't be changed (so it is stored by the driver if device
is off).
5. Booting with a value of 0 brightness (retained by bios) means the bios will set a value
of > 0, < 15 which is far too dim and was unexpected by testers. The compromise was to set the
brightness to 60 which is a usable brightness if the module init brightness was under 15.
6. When the device is off it is "unplugged"
All of the above points are addressed within the patch to create a good user experience and keep
within user expectations.
Changelog:
- V5
- Add minimum brightness to prevent screen from becoming invisible
- Previous: https://lore.kernel.org/all/20230630041743.911303-1-luke@ljones.dev/
- V4
- Fix a null dereference that happened if the display was powered off and dev struct uninitialised yet
- Previous: https://lore.kernel.org/all/20230620030033.55033-1-luke@ljones.dev/
- V3
- Refactor error handling in all functions
- V2
- Complete refactor to use as a backlight device
Luke D. Jones (1):
platform/x86: asus-wmi: add support for ASUS screenpad
drivers/platform/x86/asus-wmi.c | 131 +++++++++++++++++++++
drivers/platform/x86/asus-wmi.h | 1 +
include/linux/platform_data/x86/asus-wmi.h | 4 +
3 files changed, 136 insertions(+)
--
2.41.0
next reply other threads:[~2023-08-27 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 23:23 Luke D. Jones [this message]
2023-08-27 23:23 ` [PATCH v5 1/1] platform/x86: asus-wmi: add support for ASUS screenpad Luke D. Jones
2023-08-28 10:15 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230827232358.80512-1-luke@ljones.dev \
--to=luke@ljones.dev \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).