From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A77FC83F15 for ; Thu, 31 Aug 2023 00:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344606AbjHaADs (ORCPT ); Wed, 30 Aug 2023 20:03:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344601AbjHaADq (ORCPT ); Wed, 30 Aug 2023 20:03:46 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2217CDA for ; Wed, 30 Aug 2023 17:03:43 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-564af0ac494so286524a12.0 for ; Wed, 30 Aug 2023 17:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693440223; x=1694045023; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6VbAFF+mQ3qo4IqvELdDEKnEePt5q/NF9cOLJ4fQs4c=; b=NtTxdPtzChlphLzPyHgbZIRPE8CfMvug72kjB3FwHqjTOmd9myq9J8Tfk2maGVtMSH yjhSeihyHNphoN91OLUbGRPekKYBNHwR+yBDLAsLN2wBWUsMJaX3zfiRAH4lRXDrWZ5V jT7OhB8gOfuj/vLumSFrnyeecGERkxJtyCN/k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693440223; x=1694045023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6VbAFF+mQ3qo4IqvELdDEKnEePt5q/NF9cOLJ4fQs4c=; b=Np7q3ct3tTXvAguJNfbsoV6UOK3G7/Cne/V1dx8/Vwrl1gYuE2ZJo360z1ZdU8iTPN z6NLeuJUBRk7VOXWsr5kFWe1wSYqogp5KfVXrXvvUaZiIyanQrIXDq0DT6GkfyvsLKab //jqDQYQ4hhpfmC9mIJeH28KTDAAitq5lRtgJ7ysSpmwv7/YTGkP82h2CMBXJ3GJSvV0 LXPzcVEMCl5qyhIv3sXaP95e52YXzvWmPN/NwK+xcq9aMHCryqTC0wRyo5OMJr09JHmK dMyfevXTITH5Q0/IrWpbNuqzPzb23XzWclo5EkaYQ4EeltoGMXcx633+c7Zg+34py4mQ j4NQ== X-Gm-Message-State: AOJu0YxfsU25yTcK54zLXBxD0QQdFJgVYN8YOX6p4Av9eI3rCTaCilIp 5GzEWsxdMjjxrVqV4msfzbAg0A== X-Google-Smtp-Source: AGHT+IGzXuhNKvCDESQE2QRrtYZBrvFQDlCXvQaZKzcZ7GFJqvb5A0aJYkymW5POHQPY6ycQWRimsg== X-Received: by 2002:a17:90a:fa88:b0:26f:4685:5b66 with SMTP id cu8-20020a17090afa8800b0026f46855b66mr3639939pjb.8.1693440223411; Wed, 30 Aug 2023 17:03:43 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id ft15-20020a17090b0f8f00b002684b837d88sm152885pjb.14.2023.08.30.17.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Aug 2023 17:03:42 -0700 (PDT) Date: Wed, 30 Aug 2023 17:03:42 -0700 From: Kees Cook To: Masahiro Yamada Cc: Nicolas Schier , Michael Ellerman , Christophe Leroy , Randy Dunlap , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 0/2] kbuild: Show Kconfig fragments in "help" Message-ID: <202308301702.4EB6F55@keescook> References: <20230825194329.gonna.911-kees@kernel.org> <87ttsjlmho.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2023 at 11:57:19PM +0900, Masahiro Yamada wrote: > The attached patch will work too. > > I dropped the "in the first line" restriction > because SPDX might be placed in the first line > of config fragments. Good call. Yes, this looks excellent; thank you! Do you want to send a formal patch? Please consider it: Reviewed-by: Kees Cook -- Kees Cook