From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89442EE14D0 for ; Thu, 7 Sep 2023 00:03:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236647AbjIGADS (ORCPT ); Wed, 6 Sep 2023 20:03:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbjIGADR (ORCPT ); Wed, 6 Sep 2023 20:03:17 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 075131997 for ; Wed, 6 Sep 2023 17:03:09 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-68e3083aa1dso394196b3a.1 for ; Wed, 06 Sep 2023 17:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694044988; x=1694649788; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ti3MTuTnE8QUIsT6JhVKAYKBHjNaaV3NZtYfcLrTnyM=; b=QJhsPW5pmsVJAMPEgdoSr420jjUt8SdP9cCSdbV9l9M5C0ezH5wAPh3DFmWjbmbWbo kCRvT6CL8DQLqNDRFo4TZ93WILYOeK14WCg9gYP4xmIU2szwujaawPMmC2kfE+unmfjH kSTx6a0pkzLkeLzTEzpgqe3qBE0GfIHg9xsu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694044988; x=1694649788; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ti3MTuTnE8QUIsT6JhVKAYKBHjNaaV3NZtYfcLrTnyM=; b=Iei0xEoeXBHpnvfgFDimYTLCrRePtREjSOSAf3mlXF0KObQOPNvikj3cXwyFzqaUBq drJkyAZjFiTUX/cVNyn4HtcJk2/EbH7WZ146YUpJcQkbo854CC/POcJJDU/0uvBUFERf IzSwW3d7nrLgnhsFWECxvPyrdZOtCi6CvcTPN2s62REDM9mBnVnnxrUBNvteA05NpOK6 fhHZOY7Ai0INzwI+wWxhGXh5Eb3iXpAyoeAHIoy4PpQIKId3IOVDoA1hLf+MHeaurEw0 heTj18E9FUh4h1eNrNx7dOiUEiqtZidIYLvVacQH9UTLpSblWjlmlo0dpXOn0Ut6penf vraw== X-Gm-Message-State: AOJu0YyT41iega3ZQxkrZ/4ilxYt1OxHgXtYl7eiTEjNcbEY50Nkvc+n crLg+W0zyBmqer3s4jh3DLLIQQ== X-Google-Smtp-Source: AGHT+IFTP8tZKvLB6uavqOYtGmVlHW4eo+pUC3lCgd7rg3HzFhsrSXbcr2fuPtY2kR0VpOZ14cTQ7g== X-Received: by 2002:a05:6a00:4208:b0:68e:3614:87cb with SMTP id cd8-20020a056a00420800b0068e361487cbmr2325108pfb.8.1694044988402; Wed, 06 Sep 2023 17:03:08 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id a17-20020a62e211000000b006887b69f034sm11351432pfi.102.2023.09.06.17.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 17:03:07 -0700 (PDT) Date: Wed, 6 Sep 2023 17:03:06 -0700 From: Kees Cook To: Kent Overstreet Cc: Nathan Chancellor , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org Subject: Re: [GIT PULL] bcachefs Message-ID: <202309061658.59013483F@keescook> References: <20230903032555.np6lu5mouv5tw4ff@moria.home.lan> <20230906222847.GA230622@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906222847.GA230622@dev-arch.thelio-3990X> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06, 2023 at 03:28:47PM -0700, Nathan Chancellor wrote: > Hi Kent, > > On Sat, Sep 02, 2023 at 11:25:55PM -0400, Kent Overstreet wrote: > > here's the bcachefs pull request, for 6.6. Hopefully everything > > outstanding from the previous PR thread has been resolved; the block > > layer prereqs are in now via Jens's tree and the dcache helper has a > > reviewed-by from Christain. > > I pulled this into mainline locally and did an LLVM build, which found > an immediate issue. It appears the bcachefs codes uses zero length It looks like this series hasn't been in -next at all? That seems like a pretty important step. Also, when I look at the PR, it seems to be a branch history going back _years_. For this kind of a feature, I'd expect a short series of "here's the code" in incremental additions (e.g. look at the x86 shstk series), not the development history from it being out of tree -- this could easily lead to ugly bisection problems, etc. -Kees -- Kees Cook