From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"Sricharan Ramabadhran" <quic_srichara@quicinc.com>,
Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
Anusha Rao <quic_anusha@quicinc.com>,
Devi Priya <quic_devipriy@quicinc.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
"Kathiravan Thirumoorthy" <quic_kathirav@quicinc.com>
Subject: [PATCH v2 04/11] clk: qcom: ipq9574: drop the CLK_SET_RATE_PARENT flag from GPLL clocks
Date: Thu, 14 Sep 2023 12:29:54 +0530 [thread overview]
Message-ID: <20230913-gpll_cleanup-v2-4-c8ceb1a37680@quicinc.com> (raw)
In-Reply-To: <20230913-gpll_cleanup-v2-0-c8ceb1a37680@quicinc.com>
GPLL clock rates are fixed and shouldn't be scaled based on the request
from dependent clocks. Doing so will result in the unexpected behaviour.
So drop the CLK_SET_RATE_PARENT flag from the GPLL clocks.
Fixes: d75b82cff488 ("clk: qcom: Add Global Clock Controller driver for IPQ9574")
Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
----
Changes in V2:
- No changes
---
drivers/clk/qcom/gcc-ipq9574.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c
index 8f430367299e..e8190108e1ae 100644
--- a/drivers/clk/qcom/gcc-ipq9574.c
+++ b/drivers/clk/qcom/gcc-ipq9574.c
@@ -87,7 +87,6 @@ static struct clk_fixed_factor gpll0_out_main_div2 = {
&gpll0_main.clkr.hw
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_fixed_factor_ops,
},
};
@@ -102,7 +101,6 @@ static struct clk_alpha_pll_postdiv gpll0 = {
&gpll0_main.clkr.hw
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_alpha_pll_postdiv_ro_ops,
},
};
@@ -132,7 +130,6 @@ static struct clk_alpha_pll_postdiv gpll4 = {
&gpll4_main.clkr.hw
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_alpha_pll_postdiv_ro_ops,
},
};
@@ -162,7 +159,6 @@ static struct clk_alpha_pll_postdiv gpll2 = {
&gpll2_main.clkr.hw
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_alpha_pll_postdiv_ro_ops,
},
};
--
2.34.1
next prev parent reply other threads:[~2023-09-14 7:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 6:59 [PATCH v2 00/11] Add GPLL0 as clock provider for the Qualcomm's IPQ mailbox controller Kathiravan Thirumoorthy
2023-09-14 6:59 ` [PATCH v2 01/11] clk: qcom: ipq8074: drop the CLK_SET_RATE_PARENT flag from PLL clocks Kathiravan Thirumoorthy
2023-09-15 12:19 ` Konrad Dybcio
2023-10-19 0:16 ` Stephen Boyd
2023-10-19 11:22 ` Konrad Dybcio
2023-10-19 22:08 ` Stephen Boyd
2023-09-14 6:59 ` [PATCH v2 02/11] clk: qcom: ipq6018: " Kathiravan Thirumoorthy
2023-09-27 11:32 ` Konrad Dybcio
2023-09-14 6:59 ` [PATCH v2 03/11] clk: qcom: ipq5018: drop the CLK_SET_RATE_PARENT flag from GPLL clocks Kathiravan Thirumoorthy
2023-09-27 11:32 ` Konrad Dybcio
2023-09-14 6:59 ` Kathiravan Thirumoorthy [this message]
2023-09-27 11:32 ` [PATCH v2 04/11] clk: qcom: ipq9574: " Konrad Dybcio
2023-09-14 6:59 ` [PATCH v2 05/11] clk: qcom: ipq5332: " Kathiravan Thirumoorthy
2023-09-27 11:33 ` Konrad Dybcio
2023-09-14 6:59 ` [PATCH v2 06/11] dt-bindings: mailbox: qcom: add one more clock provider for IPQ mailbox Kathiravan Thirumoorthy
2023-09-14 6:59 ` [PATCH v2 07/11] clk: qcom: apss-ipq6018: add the GPLL0 clock also as clock provider Kathiravan Thirumoorthy
2023-09-14 6:59 ` [PATCH v2 08/11] arm64: dts: qcom: ipq8074: include the GPLL0 as clock provider for mailbox Kathiravan Thirumoorthy
2023-09-27 11:33 ` Konrad Dybcio
2023-09-27 12:12 ` Kathiravan Thirumoorthy
2023-09-14 6:59 ` [PATCH v2 09/11] arm64: dts: qcom: ipq6018: " Kathiravan Thirumoorthy
2023-09-27 11:33 ` Konrad Dybcio
2023-09-14 7:00 ` [PATCH v2 10/11] arm64: dts: qcom: ipq9574: " Kathiravan Thirumoorthy
2023-09-27 11:33 ` Konrad Dybcio
2023-09-14 7:00 ` [PATCH v2 11/11] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2023-09-27 11:33 ` Konrad Dybcio
2023-10-18 14:08 ` [PATCH v2 00/11] Add GPLL0 as clock provider for the Qualcomm's IPQ mailbox controller Kathiravan Thirumoorthy
2023-10-22 15:50 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913-gpll_cleanup-v2-4-c8ceb1a37680@quicinc.com \
--to=quic_kathirav@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).