linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wedson Almeida Filho <wedsonaf@gmail.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Wedson Almeida Filho <walmeida@microsoft.com>
Subject: [PATCH 00/29] const xattr tables
Date: Sat, 30 Sep 2023 02:00:04 -0300	[thread overview]
Message-ID: <20230930050033.41174-1-wedsonaf@gmail.com> (raw)

From: Wedson Almeida Filho <walmeida@microsoft.com>

The 's_xattr' field of 'struct super_block' currently requires a mutable
table of 'struct xattr_handler' entries (although each handler itself is
const). However, no code in vfs actually modifies the tables.

So this series changes the type of 's_xattr' to allow const tables, and
modifies existing file system to move their tables to .rodata. This is
desirable because these tables contain entries with function pointers in
them; moving them to .rodata makes it considerably less likely to be
modified accidentally or maliciously at runtime.

I found this while writing Rust abstractions for vfs.

Wedson Almeida Filho (29):
  xattr: make the xattr array itself const
  ext4: move ext4_xattr_handlers to .rodata
  9p: move xattr-related structs to .rodata
  afs: move afs_xattr_handlers to .rodata
  btrfs: move btrfs_xattr_handlers to .rodata
  ceph: move ceph_xattr_handlers to .rodata
  ecryptfs: move ecryptfs_xattr_handlers to .rodata
  erofs: move erofs_xattr_handlers and xattr_handler_map to .rodata
  ext2: move ext2_xattr_handlers and ext2_xattr_handler_map to .rodata
  f2fs: move f2fs_xattr_handlers and f2fs_xattr_handler_map to .rodata
  fuse: move fuse_xattr_handlers to .rodata
  gfs2: move gfs2_xattr_handlers_max to .rodata
  hfs: move hfs_xattr_handlers to .rodata
  hfsplus: move hfsplus_xattr_handlers to .rodata
  jffs2: move jffs2_xattr_handlers to .rodata
  jfs: move jfs_xattr_handlers to .rodata
  kernfs: move kernfs_xattr_handlers to .rodata
  nfs: move nfs4_xattr_handlers to .rodata
  ntfs3: move ntfs_xattr_handlers to .rodata
  ocfs2: move ocfs2_xattr_handlers and ocfs2_xattr_handler_map to
    .rodata
  orangefs: move orangefs_xattr_handlers to .rodata
  reiserfs: move reiserfs_xattr_handlers to .rodata
  smb: move cifs_xattr_handlers to .rodata
  squashfs: move squashfs_xattr_handlers to .rodata
  ubifs: move ubifs_xattr_handlers to .rodata
  xfs: move xfs_xattr_handlers to .rodata
  overlayfs: move xattr tables to .rodata
  shmem: move shmem_xattr_handlers to .rodata
  net: move sockfs_xattr_handlers to .rodata

 fs/9p/xattr.c                 | 8 ++++----
 fs/9p/xattr.h                 | 2 +-
 fs/afs/internal.h             | 2 +-
 fs/afs/xattr.c                | 2 +-
 fs/btrfs/xattr.c              | 2 +-
 fs/btrfs/xattr.h              | 2 +-
 fs/ceph/super.h               | 2 +-
 fs/ceph/xattr.c               | 2 +-
 fs/ecryptfs/ecryptfs_kernel.h | 2 +-
 fs/ecryptfs/inode.c           | 2 +-
 fs/erofs/xattr.c              | 2 +-
 fs/erofs/xattr.h              | 4 ++--
 fs/ext2/xattr.c               | 4 ++--
 fs/ext2/xattr.h               | 2 +-
 fs/ext4/xattr.c               | 2 +-
 fs/ext4/xattr.h               | 2 +-
 fs/f2fs/xattr.c               | 4 ++--
 fs/f2fs/xattr.h               | 2 +-
 fs/fuse/fuse_i.h              | 2 +-
 fs/fuse/xattr.c               | 2 +-
 fs/gfs2/super.h               | 4 ++--
 fs/gfs2/xattr.c               | 4 ++--
 fs/hfs/attr.c                 | 2 +-
 fs/hfs/hfs_fs.h               | 2 +-
 fs/hfsplus/xattr.c            | 2 +-
 fs/hfsplus/xattr.h            | 2 +-
 fs/jffs2/xattr.c              | 2 +-
 fs/jffs2/xattr.h              | 2 +-
 fs/jfs/jfs_xattr.h            | 2 +-
 fs/jfs/xattr.c                | 2 +-
 fs/kernfs/inode.c             | 2 +-
 fs/kernfs/kernfs-internal.h   | 2 +-
 fs/nfs/nfs.h                  | 2 +-
 fs/nfs/nfs4_fs.h              | 2 +-
 fs/nfs/nfs4proc.c             | 2 +-
 fs/ntfs3/ntfs_fs.h            | 2 +-
 fs/ntfs3/xattr.c              | 2 +-
 fs/ocfs2/xattr.c              | 4 ++--
 fs/ocfs2/xattr.h              | 2 +-
 fs/orangefs/orangefs-kernel.h | 2 +-
 fs/orangefs/xattr.c           | 2 +-
 fs/overlayfs/super.c          | 4 ++--
 fs/reiserfs/reiserfs.h        | 2 +-
 fs/reiserfs/xattr.c           | 2 +-
 fs/smb/client/cifsfs.h        | 2 +-
 fs/smb/client/xattr.c         | 2 +-
 fs/squashfs/squashfs.h        | 2 +-
 fs/squashfs/xattr.c           | 2 +-
 fs/ubifs/ubifs.h              | 2 +-
 fs/ubifs/xattr.c              | 2 +-
 fs/xattr.c                    | 6 +++---
 fs/xfs/xfs_xattr.c            | 2 +-
 fs/xfs/xfs_xattr.h            | 2 +-
 include/linux/fs.h            | 2 +-
 include/linux/pseudo_fs.h     | 2 +-
 mm/shmem.c                    | 2 +-
 net/socket.c                  | 2 +-
 57 files changed, 69 insertions(+), 69 deletions(-)


base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
-- 
2.34.1


             reply	other threads:[~2023-09-30  5:01 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30  5:00 Wedson Almeida Filho [this message]
2023-09-30  5:00 ` [PATCH 01/29] xattr: make the xattr array itself const Wedson Almeida Filho
2023-09-30  6:54   ` kernel test robot
2023-10-02  9:58   ` Thomas Weißschuh
2023-09-30  5:00 ` [PATCH 02/29] ext4: move ext4_xattr_handlers to .rodata Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 03/29] 9p: move xattr-related structs " Wedson Almeida Filho
2023-09-30  8:12   ` Christian Schoenebeck
2023-09-30  9:03     ` Dominique Martinet
2023-10-03 13:55       ` Wedson Almeida Filho
2023-10-03 21:57         ` Dominique Martinet
2023-09-30  5:00 ` [PATCH 04/29] afs: move afs_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 05/29] btrfs: move btrfs_xattr_handlers " Wedson Almeida Filho
2023-10-02 11:28   ` David Sterba
2023-10-02 11:37     ` David Sterba
2023-10-03 13:48       ` Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 06/29] ceph: move ceph_xattr_handlers " Wedson Almeida Filho
2023-10-03 14:30   ` Ilya Dryomov
2023-09-30  5:00 ` [PATCH 07/29] ecryptfs: move ecryptfs_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 08/29] erofs: move erofs_xattr_handlers and xattr_handler_map " Wedson Almeida Filho
2023-10-07  5:50   ` Gao Xiang
2023-09-30  5:00 ` [PATCH 09/29] ext2: move ext2_xattr_handlers and ext2_xattr_handler_map " Wedson Almeida Filho
2023-10-02  9:49   ` Jan Kara
2023-09-30  5:00 ` [PATCH 10/29] f2fs: move f2fs_xattr_handlers and f2fs_xattr_handler_map " Wedson Almeida Filho
2023-10-07  6:37   ` Chao Yu
2023-09-30  5:00 ` [PATCH 11/29] fuse: move fuse_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 12/29] gfs2: move gfs2_xattr_handlers_max " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 13/29] hfs: move hfs_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 14/29] hfsplus: move hfsplus_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 15/29] jffs2: move jffs2_xattr_handlers " Wedson Almeida Filho
2023-10-07  1:39   ` Zhihao Cheng
2023-09-30  5:00 ` [PATCH 16/29] jfs: move jfs_xattr_handlers " Wedson Almeida Filho
2023-10-03 14:54   ` Dave Kleikamp
2023-09-30  5:00 ` [PATCH 17/29] kernfs: move kernfs_xattr_handlers " Wedson Almeida Filho
2023-10-05 10:37   ` Greg Kroah-Hartman
2023-09-30  5:00 ` [PATCH 18/29] nfs: move nfs4_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 19/29] ntfs3: move ntfs_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 20/29] ocfs2: move ocfs2_xattr_handlers and ocfs2_xattr_handler_map " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 21/29] orangefs: move orangefs_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 22/29] reiserfs: move reiserfs_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 23/29] smb: move cifs_xattr_handlers " Wedson Almeida Filho
2023-10-01 19:59   ` Steve French
2023-09-30  5:00 ` [PATCH 24/29] squashfs: move squashfs_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 25/29] ubifs: move ubifs_xattr_handlers " Wedson Almeida Filho
2023-10-07  1:39   ` Zhihao Cheng
2023-09-30  5:00 ` [PATCH 26/29] xfs: move xfs_xattr_handlers " Wedson Almeida Filho
2023-10-01 16:18   ` Darrick J. Wong
2023-09-30  5:00 ` [PATCH 27/29] overlayfs: move xattr tables " Wedson Almeida Filho
2023-10-03 16:41   ` Amir Goldstein
2023-09-30  5:00 ` [PATCH 28/29] shmem: move shmem_xattr_handlers " Wedson Almeida Filho
2023-09-30  5:00 ` [PATCH 29/29] net: move sockfs_xattr_handlers " Wedson Almeida Filho
2023-10-04 21:24   ` Jakub Kicinski
2023-10-03 13:28 ` [PATCH 00/29] const xattr tables Christian Brauner
2023-10-09 14:43 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230930050033.41174-1-wedsonaf@gmail.com \
    --to=wedsonaf@gmail.com \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=walmeida@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).