linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, jbaron@akamai.com,
	gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch, jani.nikula@intel.com,
	ville.syrjala@linux.intel.com, seanpaul@chromium.org,
	robdclark@gmail.com, groeck@google.com, yanivt@google.com,
	bleung@google.com, linux-doc@vger.kernel.org,
	Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH v7 03/25] dyndbg: make ddebug_class_param union members same size
Date: Thu, 12 Oct 2023 11:21:14 -0600	[thread overview]
Message-ID: <20231012172137.3286566-4-jim.cromie@gmail.com> (raw)
In-Reply-To: <20231012172137.3286566-1-jim.cromie@gmail.com>

struct ddebug_class_param keeps a ref to the state-storage of the
param, make both flavors use the same unsigned long under-type.
ISTM this is simpler and safer.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 include/linux/dynamic_debug.h | 2 +-
 lib/dynamic_debug.c           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 4fcbf4d4fd0a..5231aaf361c4 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -124,7 +124,7 @@ struct _ddebug_info {
 struct ddebug_class_param {
 	union {
 		unsigned long *bits;
-		unsigned int *lvl;
+		unsigned long *lvl;
 	};
 	char flags[8];
 	const struct ddebug_class_map *map;
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index ceb3067a5c83..b984ce338921 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -796,7 +796,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)
 
 	case DD_CLASS_TYPE_LEVEL_NAMES:
 	case DD_CLASS_TYPE_LEVEL_NUM:
-		return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl);
+		return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl);
 	default:
 		return -1;
 	}
-- 
2.41.0


  parent reply	other threads:[~2023-10-12 17:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 17:21 [PATCH v7 00/25] fix DRM_USE_DYNAMIC_DEBUG=y regression Jim Cromie
2023-10-12 17:21 ` [PATCH v7 01/25] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2023-10-12 17:21 ` [PATCH v7 02/25] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2023-10-12 17:21 ` Jim Cromie [this message]
2023-10-12 17:21 ` [PATCH v7 04/25] dyndbg: replace classmap list with a vector Jim Cromie
2023-10-12 17:21 ` [PATCH v7 05/25] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Jim Cromie
2023-10-12 17:21 ` [PATCH v7 06/25] dyndbg: split param_set_dyndbg_classes to module/wrapper fns Jim Cromie
2023-10-12 17:21 ` [PATCH v7 07/25] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2023-10-12 17:21 ` [PATCH v7 08/25] dyndbg: reduce verbose/debug clutter Jim Cromie
2023-10-12 17:21 ` [PATCH v7 09/25] dyndbg: silence debugs with no-change updates Jim Cromie
2023-10-12 17:21 ` [PATCH v7 10/25] dyndbg: tighten ddebug_class_name() 1st arg type Jim Cromie
2023-10-12 17:21 ` [PATCH v7 11/25] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2023-10-12 17:21 ` [PATCH v7 12/25] dyndbg: reduce verbose=3 messages in ddebug_add_module Jim Cromie
2023-10-12 17:21 ` [PATCH v7 13/25] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2023-10-12 17:21 ` [PATCH v7 14/25] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-10-12 17:21 ` [PATCH v7 15/25] dyndbg: add for_each_boxed_vector Jim Cromie
2023-10-12 17:21 ` [PATCH v7 16/25] dyndbg: refactor ddebug_classparam_clamp_input Jim Cromie
2023-10-12 17:21 ` [PATCH v7 17/25] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API Jim Cromie
2023-10-12 17:21 ` [PATCH v7 18/25] dyndbg-doc: add classmap info to howto Jim Cromie
2023-10-12 17:21 ` [PATCH v7 19/25] dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED Jim Cromie
2023-10-12 17:21 ` [PATCH v7 20/25] dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP Jim Cromie
2023-10-12 17:21 ` [PATCH v7 21/25] dyndbg: refactor *dynamic_emit_prefix Jim Cromie
2023-10-12 17:21 ` [PATCH v7 22/25] dyndbg: improve err report in attach_user_module_classes Jim Cromie
2023-10-12 17:21 ` [PATCH v7 23/25] drm: use correct ccflags-y spelling Jim Cromie
2023-10-12 17:21 ` [PATCH v7 24/25] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers Jim Cromie
2023-10-12 17:21 ` [PATCH v7 25/25] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231012172137.3286566-4-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bleung@google.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jbaron@akamai.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=ville.syrjala@linux.intel.com \
    --cc=yanivt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).