From: Leon Romanovsky <leonro@nvidia.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Saeed Mahameed <saeed@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>, Jason Gunthorpe <jgg@nvidia.com>,
Jiri Pirko <jiri@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH 2/5] misc: mlx5ctl: Add mlx5ctl misc driver
Date: Wed, 18 Oct 2023 13:00:14 +0300 [thread overview]
Message-ID: <20231018100014.GG5392@unreal> (raw)
In-Reply-To: <2023101814-thirsting-culture-1a4c@gregkh>
On Wed, Oct 18, 2023 at 10:55:35AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 18, 2023 at 11:49:08AM +0300, Leon Romanovsky wrote:
> > On Wed, Oct 18, 2023 at 10:30:00AM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 18, 2023 at 01:19:38AM -0700, Saeed Mahameed wrote:
> > > > +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
> > >
> > > For dual-licensed code, I need a LOT of documentation as to why this
> > > must be dual-licensed, AND a signed-off-by from your corporate lawyer
> > > agreeing to it so they convey an understanding of just how complex and
> > > messy this will get over time and what you are agreeing to do here.
> >
> > This is how we (NBU, Networking Business Unit in Nvidia, former Mellanox)
> > are instructed to submit all our code by default. This license is aligned
> > with our networking, vdpa and RDMA code.
>
> Please don't do this without a really really good reason. Especially
> for a "misc" driver that is so linux-dependant here.
Like I said, it is our default license. Saeed will change this code to be GPL-only.
> The "Linux-OpenIB" license is old, obsolete, and problematic and should not be added to any
> new files in the kernel tree, outside of the island of
> drivers/infiniband/ as you all insist on that crazyness there.
>
> Heck, it's even documented that you shouldn't be adding that license to
> any new files, why ignore that?
I don't remember being asked about it, not in this patch
https://lore.kernel.org/all/20180425203703.568152337@linutronix.de/
and not in this later patch which changed LICENSES/other/ to be
LICENSES/deprecated/
https://lore.kernel.org/all/20190430105130.24500-4-hch@lst.de/
So it is nice that someone decided to deprecate it without notifying users
about such change. It will be better to put Linux-OpenIB to LICENSES/dual/
folder instead.
Our lawyers are perfectly fine with Linux-OpenIB license.
Thanks
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-10-18 10:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 8:19 [PATCH 0/5] mlx5 ConnectX diagnostic misc driver Saeed Mahameed
2023-10-18 8:19 ` [PATCH 1/5] mlx5: Add aux dev for ctl interface Saeed Mahameed
2023-10-18 8:19 ` [PATCH 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Saeed Mahameed
2023-10-18 8:30 ` Greg Kroah-Hartman
2023-10-18 8:49 ` Leon Romanovsky
2023-10-18 8:55 ` Greg Kroah-Hartman
2023-10-18 10:00 ` Leon Romanovsky [this message]
2023-10-18 11:52 ` Greg Kroah-Hartman
2023-10-18 18:01 ` Jason Gunthorpe
2023-10-18 18:22 ` Greg Kroah-Hartman
2023-10-18 18:56 ` Jason Gunthorpe
2023-10-19 17:21 ` Greg Kroah-Hartman
2023-10-19 19:00 ` Jason Gunthorpe
2023-10-19 19:46 ` Greg Kroah-Hartman
2023-10-19 23:49 ` Jason Gunthorpe
2023-10-20 20:17 ` Greg Kroah-Hartman
2023-10-19 21:50 ` Dual licensing [was: [PATCH 2/5] misc: mlx5ctl: Add mlx5ctl misc driver] Jonathan Corbet
2023-10-20 19:30 ` Dave Airlie
2023-10-20 20:07 ` Greg Kroah-Hartman
2023-10-18 8:30 ` [PATCH 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Greg Kroah-Hartman
2023-10-18 8:19 ` [PATCH 3/5] misc: mlx5ctl: Add info ioctl Saeed Mahameed
2023-10-18 9:02 ` Arnd Bergmann
2023-10-18 10:08 ` Leon Romanovsky
2023-10-18 11:02 ` Arnd Bergmann
2023-10-22 1:46 ` kernel test robot
2023-10-22 11:27 ` kernel test robot
2023-10-18 8:19 ` [PATCH 4/5] misc: mlx5ctl: Add command rpc ioctl Saeed Mahameed
2023-10-18 8:19 ` [PATCH 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl Saeed Mahameed
2023-10-18 8:33 ` Greg Kroah-Hartman
2023-11-19 9:49 ` Saeed Mahameed
2023-10-18 9:30 ` Arnd Bergmann
2023-10-18 11:51 ` Jason Gunthorpe
2023-11-19 9:44 ` Saeed Mahameed
2023-10-18 8:31 ` [PATCH 0/5] mlx5 ConnectX diagnostic misc driver Greg Kroah-Hartman
2023-10-18 12:00 ` Jason Gunthorpe
2023-10-18 12:11 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018100014.GG5392@unreal \
--to=leonro@nvidia.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=jiri@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).