From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F54FCDB47E for ; Wed, 18 Oct 2023 13:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231620AbjJRN0W (ORCPT ); Wed, 18 Oct 2023 09:26:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbjJRN0Q (ORCPT ); Wed, 18 Oct 2023 09:26:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6044138 for ; Wed, 18 Oct 2023 06:26:13 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12588C433C7; Wed, 18 Oct 2023 13:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697635573; bh=QibHFyUe/EPNDDhU4KtzbtUNy6mOEodj9TioLZzQ+ag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wGTnNf+Ys3HVCRBatDeBspYArhSkDCQq/SJ9wJ9HoGw7Id72lDTvgas8JTPUmzkHY vA6bz2PyxeGX2TfoNQmOtqtKhXx31EXv9XE/UYesjYil0+FT8Gxe0Mvko+fb1ILgK3 NfsPThfMoOw2dFebarl11b1szGByIC4w0Ksvn8ao= Date: Wed, 18 Oct 2023 15:26:07 +0200 From: Greg Kroah-Hartman To: Soumya Negi Cc: Martyn Welch , Manohar Vanga , outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*() Message-ID: <2023101823-unhidden-draw-d68c@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 17, 2023 at 09:36:32PM -0700, Soumya Negi wrote: > vme.c uses printk() to log messages. To improve and standardize message > formatting, use logging mechanisms pr_err()/pr_warn() and > dev_err()/dev_warn() instead. Retain the printk log levels of the > messages during replacement. > > Issue found by checkpatch.pl > > Signed-off-by: Soumya Negi > --- > drivers/staging/vme_user/vme.c | 175 ++++++++++++++++++--------------- > 1 file changed, 94 insertions(+), 81 deletions(-) > > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c > index 6519a7c994a0..e8c2c1e77b7d 100644 > --- a/drivers/staging/vme_user/vme.c > +++ b/drivers/staging/vme_user/vme.c > @@ -9,6 +9,8 @@ > * Copyright 2004 Motorola Inc. > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt No, this is a driver, as others have pointed out, always use dev_*() calls instead. Yes, that means that sometimes you do need to propagate the proper device to the function, but that's ok, it's the correct solution here. thanks, greg k-h