From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B1DBC001DF for ; Thu, 19 Oct 2023 21:18:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346561AbjJSVSX (ORCPT ); Thu, 19 Oct 2023 17:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231495AbjJSVSW (ORCPT ); Thu, 19 Oct 2023 17:18:22 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB5E0113 for ; Thu, 19 Oct 2023 14:18:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A7AAC433C7; Thu, 19 Oct 2023 21:18:19 +0000 (UTC) Date: Thu, 19 Oct 2023 17:18:16 -0400 From: Steven Rostedt To: "Matthew Wilcox (Oracle)" Cc: Kees Cook , Christoph Hellwig , Justin Stitt , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Overstreet , Petr Mladek , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky Subject: Re: [PATCH 0/1] Put seq_buf on a diet Message-ID: <20231019171746.3da43332@gandalf.local.home> In-Reply-To: <20231019171439.1c50a16e@gandalf.local.home> References: <20231019194514.2115506-1-willy@infradead.org> <20231019171439.1c50a16e@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Oct 2023 17:14:39 -0400 Steven Rostedt wrote: > On Thu, 19 Oct 2023 20:45:13 +0100 > "Matthew Wilcox (Oracle)" wrote: > > > Prompted by the recent mails on ksummit, let's actually try to make this > > work this time. We need a container for manipulating strings easily, > > and seq_buf is the closest thing we have to it. The only problem I have > > with it is the readpos that is only useful for the tracing code today. > > So move it from the seq_buf to the tracing code. > > > > We should go further with this patch series, including using seq_buf > > within vsprintf, but if we can't get over this hurdle first, I'm not > > going to waste my time on this again. > > > > Matthew Wilcox (Oracle) (1): > > trace: Move readpos from seq_buf to trace_seq > > > > include/linux/seq_buf.h | 5 +---- > > include/linux/trace_seq.h | 2 ++ > > kernel/trace/trace.c | 10 +++++----- > > kernel/trace/trace_seq.c | 6 +++++- > > lib/seq_buf.c | 13 +++++-------- > > 5 files changed, 18 insertions(+), 18 deletions(-) > > > > Thanks Matthew, I'll pull this in and add it to my for-next queue (after > testing) Actually, Can you resend it, and Cc: linux-trace-kernel@vger.kernel.org so that it goes into patchwork. Thanks! -- Steve