From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB09C001DF for ; Fri, 20 Oct 2023 00:16:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346772AbjJTAQt (ORCPT ); Thu, 19 Oct 2023 20:16:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346721AbjJTAQr (ORCPT ); Thu, 19 Oct 2023 20:16:47 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBDC3126; Thu, 19 Oct 2023 17:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697761004; x=1729297004; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BqX6CmbZGsKDvvqm0PW9nz8RCwYq9ztprkqxDl3ZOck=; b=LJhyPxuxztWMU4N4fFVzKQQT97LJfdhAgDFjAnq5xwy+e7XE0kJnE4BZ Lluna8QPyda37PE2IpiVB6UeN1PlJCGvte1mrY42xDHodSpVCT2q880PL JnUY63ZYhMECDI5TA7lRnWUkdIweBD2T+78KHNXk4cywUGwRownkHrCAT jvgCVtoxvy8xD9mJdmuTynTRKnUZxoqnnail3C7UFaO589i3AW+0/R6En 6Ij/wMxhVUL0NPgULX49jxOvzZAN0z/tiqlPLBmRuOOuqRhXTPi2svPgY PB3QueYOlDQ6Bo5SZxHIggtTjVK/EnhcSDprPzzAI44jXrYPzJbDBAtdy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="389260753" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="389260753" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 17:16:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="847897226" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="847897226" Received: from lkp-server01.sh.intel.com (HELO 8917679a5d3e) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 19 Oct 2023 17:16:36 -0700 Received: from kbuild by 8917679a5d3e with local (Exim 4.96) (envelope-from ) id 1qtdBq-0002lg-27; Fri, 20 Oct 2023 00:16:34 +0000 Date: Fri, 20 Oct 2023 08:15:44 +0800 From: kernel test robot To: Geert Uytterhoeven , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker Cc: oe-kbuild-all@lists.linux.dev, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH -next v2] sunrpc: Use no_printk() in dfprintk*() dummies Message-ID: <202310200734.I6x6UCe1-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, kernel test robot noticed the following build errors: [auto build test ERROR on next-20231016] url: https://github.com/intel-lab-lkp/linux/commits/Geert-Uytterhoeven/sunrpc-Use-no_printk-in-dfprintk-dummies/20231017-104813 base: next-20231016 patch link: https://lore.kernel.org/r/a93de2e8afa826745746b00fc5f64e513df5d52f.1697104757.git.geert%2Brenesas%40glider.be patch subject: [PATCH -next v2] sunrpc: Use no_printk() in dfprintk*() dummies config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20231020/202310200734.I6x6UCe1-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231020/202310200734.I6x6UCe1-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310200734.I6x6UCe1-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:31, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/current.h:10, from include/linux/sched.h:12, from include/linux/sunrpc/svcauth_gss.h:12, from fs/nfsd/nfsfh.c:13: fs/nfsd/nfsfh.c: In function 'nfsd_setuser_and_check_port': >> fs/nfsd/nfsfh.c:111:47: error: 'buf' undeclared (first use in this function) 111 | svc_print_addr(rqstp, buf, sizeof(buf))); | ^~~ include/linux/printk.h:427:33: note: in definition of macro 'printk_index_wrap' 427 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/printk.h:129:17: note: in expansion of macro 'printk' 129 | printk(fmt, ##__VA_ARGS__); \ | ^~~~~~ include/linux/sunrpc/debug.h:70:41: note: in expansion of macro 'no_printk' 70 | # define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) | ^~~~~~~~~ include/linux/sunrpc/debug.h:25:9: note: in expansion of macro 'dfprintk' 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__) | ^~~~~~~~ fs/nfsd/nfsfh.c:110:17: note: in expansion of macro 'dprintk' 110 | dprintk("nfsd: request from insecure port %s!\n", | ^~~~~~~ fs/nfsd/nfsfh.c:111:47: note: each undeclared identifier is reported only once for each function it appears in 111 | svc_print_addr(rqstp, buf, sizeof(buf))); | ^~~ include/linux/printk.h:427:33: note: in definition of macro 'printk_index_wrap' 427 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/printk.h:129:17: note: in expansion of macro 'printk' 129 | printk(fmt, ##__VA_ARGS__); \ | ^~~~~~ include/linux/sunrpc/debug.h:70:41: note: in expansion of macro 'no_printk' 70 | # define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) | ^~~~~~~~~ include/linux/sunrpc/debug.h:25:9: note: in expansion of macro 'dfprintk' 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__) | ^~~~~~~~ fs/nfsd/nfsfh.c:110:17: note: in expansion of macro 'dprintk' 110 | dprintk("nfsd: request from insecure port %s!\n", | ^~~~~~~ vim +/buf +111 fs/nfsd/nfsfh.c 9d7ed1355db5b0 J. Bruce Fields 2018-03-08 101 6fa02839bf9412 J. Bruce Fields 2007-11-12 102 static __be32 nfsd_setuser_and_check_port(struct svc_rqst *rqstp, 6fa02839bf9412 J. Bruce Fields 2007-11-12 103 struct svc_export *exp) 6fa02839bf9412 J. Bruce Fields 2007-11-12 104 { 12045a6ee9908b J. Bruce Fields 2009-12-08 105 int flags = nfsexp_flags(rqstp, exp); 12045a6ee9908b J. Bruce Fields 2009-12-08 106 6fa02839bf9412 J. Bruce Fields 2007-11-12 107 /* Check if the request originated from a secure port. */ 9d7ed1355db5b0 J. Bruce Fields 2018-03-08 108 if (!nfsd_originating_port_ok(rqstp, flags)) { 5216a8e70e25b0 Pavel Emelyanov 2008-02-21 109 RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); a48fd0f9f77b6e Kinglong Mee 2014-05-29 110 dprintk("nfsd: request from insecure port %s!\n", 6fa02839bf9412 J. Bruce Fields 2007-11-12 @111 svc_print_addr(rqstp, buf, sizeof(buf))); 6fa02839bf9412 J. Bruce Fields 2007-11-12 112 return nfserr_perm; 6fa02839bf9412 J. Bruce Fields 2007-11-12 113 } 6fa02839bf9412 J. Bruce Fields 2007-11-12 114 6fa02839bf9412 J. Bruce Fields 2007-11-12 115 /* Set user creds for this exportpoint */ 6fa02839bf9412 J. Bruce Fields 2007-11-12 116 return nfserrno(nfsd_setuser(rqstp, exp)); 6fa02839bf9412 J. Bruce Fields 2007-11-12 117 } 6fa02839bf9412 J. Bruce Fields 2007-11-12 118 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki