From: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kumaran.4353@gmail.com
Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis
Date: Sat, 21 Oct 2023 06:35:27 -0700 [thread overview]
Message-ID: <20231021133527.GB12776@ubuntu> (raw)
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kumaran.4353@gmail.com
Bcc:
Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis
Reply-To:
In-Reply-To: <2023102131-slacker-lily-28ff@gregkh>
On Sat, Oct 21, 2023 at 11:48:32AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 19, 2023 at 02:39:49PM -0700, Nandha Kumar Singaram wrote:
> > Adhere to linux coding style. Reported by checkpatch.pl:
> > CHECK: Alignment should match open parenthesis
> >
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> > ---
> > drivers/staging/greybus/camera.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> > index cdbb42cd413b..405c8e78aa72 100644
> > --- a/drivers/staging/greybus/camera.c
> > +++ b/drivers/staging/greybus/camera.c
> > @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
> > }
> >
> > static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> > - struct gb_camera_configure_streams_response *resp)
> > + struct gb_camera_configure_streams_response *resp)
> > {
> > unsigned int max_pkt_size = 0;
> > unsigned int i;
> > @@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> > * Validate the stream configuration response verifying padding is correctly
> > * set and the returned number of streams is supported
> > */
> > -static const int gb_camera_configure_streams_validate_response(
> > - struct gb_camera *gcam,
> > +static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
>
> Why change this line?
>
did these Code change to fix CHECK: Lines should not end with a '(' reported by
checkpatch.pl
> It's fine, but then:
>
> > struct gb_camera_configure_streams_response *resp,
> > unsigned int nstreams)
>
> These lines are not fixed up?
>
> thanks,
>
> greg k-h
Fixing these lines results in another checkpatch check(CHECK: line length
of 113 exceeds 100 columns) so didn't added any change
Thanks,
Nandha Kumar
next reply other threads:[~2023-10-21 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 13:35 Nandha Kumar Singaram [this message]
2023-10-21 14:45 ` [PATCH] staging: greybus: Alignment should match open parenthesis Greg Kroah-Hartman
2023-10-21 18:06 ` Nandha Kumar Singaram
2023-10-21 19:16 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2023-10-19 21:39 Nandha Kumar Singaram
2023-10-20 0:15 ` Alex Elder
2023-10-21 13:05 ` Nandha Kumar Singaram
2023-10-21 9:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231021133527.GB12776@ubuntu \
--to=nandhakumar.singaram@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=kumaran.4353@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).