From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F859C25B46 for ; Mon, 23 Oct 2023 17:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbjJWRxg (ORCPT ); Mon, 23 Oct 2023 13:53:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjJWRxf (ORCPT ); Mon, 23 Oct 2023 13:53:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF96A3 for ; Mon, 23 Oct 2023 10:53:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 251F2C433C8; Mon, 23 Oct 2023 17:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1698083613; bh=Jhe+XeYG4ZAoofviz9gMtylgOsjcE4B/E4TIZ4/ULYY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=znZz8Fvr9vsi/Ax5MK6Q0e1d5+aKpOuPFM+pmFrvJosqNV/l7E/O7cI78iKyxD2aL YrTcgowceF+hp8sB/vgDoBCqtR5z3LCrDKbTtar6dV4vvUkfPItqJY2NBzoQ6TvnTt eaDlEFX1v9vF1pawCL+4Irduz9naDJ+XjaTZFSuw= Date: Mon, 23 Oct 2023 10:53:31 -0700 From: Andrew Morton To: domenico cerasuolo Cc: Hugh Dickins , Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , "Huang, Ying" , Nhat Pham , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 10/12] mempolicy: alloc_pages_mpol() for NUMA policy without vma Message-Id: <20231023105331.311373ed33a0dfe78ddaa9e5@linux-foundation.org> In-Reply-To: References: <74e34633-6060-f5e3-aee-7040d43f2e93@google.com> <1738368e-bac0-fd11-ed7f-b87142a939fe@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Oct 2023 18:53:26 +0200 domenico cerasuolo wrote: > > Rebased to mm.git's current mm-stable, to resolve with removal of > > vma_policy() from include/linux/mempolicy.h, and temporary omission > > of Nhat's ZSWAP mods from mm/swap_state.c: no other changes. > > Hi Hugh, > > not sure if it's the rebase, but I don't see an update to > __read_swap_cache_async invocation in zswap.c at line 1078. Shouldn't we pass a > mempolicy there too? No change needed. zswap_writeback_entry() was passing a NULL for arg `vma' and it's now passing a NULL for arg `mpol'.