From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B48C61D97 for ; Wed, 22 Nov 2023 02:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343523AbjKVCOh (ORCPT ); Tue, 21 Nov 2023 21:14:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbjKVCOg (ORCPT ); Tue, 21 Nov 2023 21:14:36 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA91298; Tue, 21 Nov 2023 18:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1700619270; bh=jMhp3OO1OuD6ZqqAsOzECGZ72/P154caojLkXwRL41U=; h=Date:From:To:Cc:Subject:From; b=LT5DOMUGm6oxoBluIfXnUbTw906Ry0buC3EaQQnVidLlrMLljA2K40T2xlof4w/Ag sHlnqbuLOtBbNeMAbIizkhafQEnta+dd7I8DQazbOL60zdUsWaB0X0U22xto88mjoR dykM7PJNh4DPm70zxYi+QbTX8SqsxcXpmU2Uhwv03hf5biTxjvrJVNRjoLS3jJYx9o 6ovPPqQkk27PyjdBDCdAIZ1So3AXyRSHI6M1QIL7ECGuL8dlMBwUvGKc9e2LhyHlTd 4XMyeh6A1UsNJUI+oljCmwjRr26EqQU7eDsekA33LwPZaw7jX3fnJlelBLFa6ZaMmz aOYz2AOtzsIHQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SZlDj1X1Mz4xSQ; Wed, 22 Nov 2023 13:14:29 +1100 (AEDT) Date: Wed, 22 Nov 2023 13:14:28 +1100 From: Stephen Rothwell To: Paolo Bonzini , Christian Brauner Cc: KVM , "Matthew Wilcox (Oracle)" , Ackerley Tng , Chao Peng , Isaku Yamahata , "Kirill A. Shutemov" , Michael Roth , Sean Christopherson , Yu Zhang , Linux Kernel Mailing List , Linux Next Mailing List Subject: linux-next: build failure after merge of the kvm tree Message-ID: <20231122131428.599f2931@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/GLQFgBlUXh5M6MunK=g/i._"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/GLQFgBlUXh5M6MunK=g/i._ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, After merging the kvm tree, today's linux-next build (x86_64 allmodconfig) failed like this: arch/x86/kvm/../../../virt/kvm/guest_memfd.c: In function 'kvm_gmem_punch_h= ole': arch/x86/kvm/../../../virt/kvm/guest_memfd.c:100:58: error: 'struct address= _space' has no member named 'private_list'; did you mean 'i_private_list'? 100 | struct list_head *gmem_list =3D &inode->i_mapping->private_= list; | ^~~~~~~~~~= ~~ | i_private_= list arch/x86/kvm/../../../virt/kvm/guest_memfd.c: In function 'kvm_gmem_error_f= olio': arch/x86/kvm/../../../virt/kvm/guest_memfd.c:273:49: error: 'struct address= _space' has no member named 'private_list'; did you mean 'i_private_list'? 273 | struct list_head *gmem_list =3D &mapping->private_list; | ^~~~~~~~~~~~ | i_private_list arch/x86/kvm/../../../virt/kvm/guest_memfd.c: In function '__kvm_gmem_creat= e': arch/x86/kvm/../../../virt/kvm/guest_memfd.c:373:51: error: 'struct address= _space' has no member named 'private_list'; did you mean 'i_private_list'? 373 | list_add(&gmem->entry, &inode->i_mapping->private_list); | ^~~~~~~~~~~~ | i_private_list Caused by commit a7800aa80ea4 ("KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific= backing memory") interacting with commit 488e2eea5100 ("fs: Rename mapping private members") from the vfs-brauner tree. I have applied the following merge fix patch. From: Stephen Rothwell Date: Wed, 22 Nov 2023 13:10:06 +1100 Subject: [PATCH] fix up for "KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for gu= est-specific backing memory" interacting with "fs: Rename mapping private members" from the vfs-brauner tree. Signed-off-by: Stephen Rothwell --- virt/kvm/guest_memfd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index 451435123fe7..16d58806e913 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -97,7 +97,7 @@ static void kvm_gmem_invalidate_end(struct kvm_gmem *gmem= , pgoff_t start, =20 static long kvm_gmem_punch_hole(struct inode *inode, loff_t offset, loff_t= len) { - struct list_head *gmem_list =3D &inode->i_mapping->private_list; + struct list_head *gmem_list =3D &inode->i_mapping->i_private_list; pgoff_t start =3D offset >> PAGE_SHIFT; pgoff_t end =3D (offset + len) >> PAGE_SHIFT; struct kvm_gmem *gmem; @@ -270,7 +270,7 @@ static int kvm_gmem_migrate_folio(struct address_space = *mapping, static int kvm_gmem_error_folio(struct address_space *mapping, struct folio *folio) { - struct list_head *gmem_list =3D &mapping->private_list; + struct list_head *gmem_list =3D &mapping->i_private_list; struct kvm_gmem *gmem; pgoff_t start, end; =20 @@ -370,7 +370,7 @@ static int __kvm_gmem_create(struct kvm *kvm, loff_t si= ze, u64 flags) kvm_get_kvm(kvm); gmem->kvm =3D kvm; xa_init(&gmem->bindings); - list_add(&gmem->entry, &inode->i_mapping->private_list); + list_add(&gmem->entry, &inode->i_mapping->i_private_list); =20 fd_install(fd, file); return fd; --=20 2.40.1 --=20 Cheers, Stephen Rothwell --Sig_/GLQFgBlUXh5M6MunK=g/i._ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmVdZAQACgkQAVBC80lX 0Gy7+wf8COi5Jx/3jUo0LmfleOMMQZcluv5ylZ8f9gfVZsxnt9C7gMoNVkAHzup0 u1IY0VZss3/exLMzL6TOKOCQlzub5qmMkYdL7HD9YzKrbwU/EFm3nX2r60RsATc6 fCWtDRcEludWMQemnW4ZiWKXylD7Nj4o4IReIVqdDDs98R7JnHwMRBB7bwSGe8Jx ZdijsunCXPehjZRcIOjUs452+ELXnF8f+JDc9nSkOe8PBEz9rhpv0iaHUnHV1/uE V651+TLvK5gcgXiz8lZesr3O2tSuXck6fyAbT3s8bXTjmNr6dnV6rZbzhWhUC5vm mtQltBcVO7y6wvxwfKNWlgwpa65RLg== =nvCs -----END PGP SIGNATURE----- --Sig_/GLQFgBlUXh5M6MunK=g/i._--