From: Lee Jones <lee@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Cc: tony@atomide.com, robh@kernel.org, wens@csie.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: twl6030-irq: Revert to use of_match_device()
Date: Thu, 23 Nov 2023 10:41:08 +0000 [thread overview]
Message-ID: <20231123104108.GF1184245@google.com> (raw)
In-Reply-To: <20231123103756.GD1184245@google.com>
On Thu, 23 Nov 2023, Lee Jones wrote:
> On Sun, 29 Oct 2023, Peter Ujfalusi wrote:
>
> > The core twl chip is probed via i2c and the dev->driver->of_match_table is
> > NULL, causing the driver to fail to probe.
> >
> > This partially reverts commit 1e0c866887f4.
> >
> > Fixes: 1e0c866887f4 ("mfd: Use device_get_match_data() in a bunch of drivers")
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> > ---
> > drivers/mfd/twl6030-irq.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
> > index f9fce8408c2c..3c03681c124c 100644
> > --- a/drivers/mfd/twl6030-irq.c
> > +++ b/drivers/mfd/twl6030-irq.c
> > @@ -24,10 +24,10 @@
> > #include <linux/kthread.h>
> > #include <linux/mfd/twl.h>
> > #include <linux/platform_device.h>
> > -#include <linux/property.h>
> > #include <linux/suspend.h>
> > #include <linux/of.h>
> > #include <linux/irqdomain.h>
> > +#include <linux/of_device.h>
> >
> > #include "twl-core.h"
> >
> > @@ -368,10 +368,10 @@ int twl6030_init_irq(struct device *dev, int irq_num)
> > int nr_irqs;
> > int status;
> > u8 mask[3];
> > - const int *irq_tbl;
> > + const struct of_device_id *of_id;
> >
> > - irq_tbl = device_get_match_data(dev);
> > - if (!irq_tbl) {
> > + of_id = of_match_device(twl6030_of_match, dev);
>
> I think you just dropped support for ACPI.
Ah, scrap that. I was looking at the wrong part of 1e0c866887f4.
So what about the other drivers changed in the aforementioned commit?
Ideally we'd have a call that covers all of the various probing APIs.
> Rob, care to follow-up?
I'd still like Rob to comment.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-11-23 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 11:48 [PATCH] mfd: twl6030-irq: Revert to use of_match_device() Peter Ujfalusi
2023-11-23 10:37 ` Lee Jones
2023-11-23 10:41 ` Lee Jones [this message]
2023-11-23 15:40 ` Péter Ujfalusi
2023-11-30 14:05 ` Lee Jones
2023-12-01 11:30 ` (subset) " Lee Jones
2024-02-19 9:52 ` Andreas Schwab
2024-02-19 14:33 ` Lee Jones
2024-02-26 11:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123104108.GF1184245@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).