From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0D0C4167B for ; Mon, 27 Nov 2023 08:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230234AbjK0Iiv (ORCPT ); Mon, 27 Nov 2023 03:38:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232609AbjK0IZn (ORCPT ); Mon, 27 Nov 2023 03:25:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDE6182 for ; Mon, 27 Nov 2023 00:25:49 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B359BC433C7; Mon, 27 Nov 2023 08:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701073549; bh=32wd1LcJrhba6MmZdU1Ep6DLsF6PtYHOka5p4OoEN7E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lQjqsSBDpVX8/Pudoyw1tQTn/zeDfj8cwIRL7M5zy5QQCKAlm7tGi0OFB8NbASVyg gzBapnMQxC4ymPkoEV2OQFbY7XheY0eQOYH+8f4mntH4YsAt54m8JXUDwPFEqeNB+1 JbM7nfZ1wPJQlIZMsav9sWugi5ljcuR+SbrlSo/w= Date: Mon, 27 Nov 2023 08:25:46 +0000 From: Greg KH To: Andreas Kemnade Cc: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, johan@kernel.org, arnd@arndb.de, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com, Tony Lindgren , =?iso-8859-1?Q?P=E9ter?= Ujfalusi , robh@kernel.org Subject: Re: [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit Message-ID: <2023112729-qualify-relearn-6a72@gregkh> References: <20231126191840.110564-1-andreas@kemnade.info> <20231126191840.110564-4-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231126191840.110564-4-andreas@kemnade.info> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote: > The TI-ST driver seems not to be used anymore. For bluetooth needs > there is hci_ll.c which has device tree support and can work without > this one. Also firmware download support is there, so it is also not needed > here. GPS can also reuse parts of the framework in hci_ll > > Contrary from this driver, device tree support has been removed. > > So start deorbiting it by marking it as broken. > > Signed-off-by: Andreas Kemnade > --- > drivers/misc/ti-st/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > index 1503a6496f632..6bf9cc845745c 100644 > --- a/drivers/misc/ti-st/Kconfig > +++ b/drivers/misc/ti-st/Kconfig > @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline" > config TI_ST > tristate "Shared transport core driver" > depends on NET && TTY > - depends on GPIOLIB || COMPILE_TEST > + depends on GPIOLIB || COMPILE_TEST || BROKEN Why not just delete it? Why have it stick around any longer? thanks, greg k-h