From: "Michael Büsch" <m@bues.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: sunying@isrc.iscas.ac.cn, linux-kernel@vger.kernel.org,
Neal Liu <neal_liu@aspeedtech.com>,
David Howells <dhowells@redhat.com>,
linux-crypto@vger.kernel.org,
"pengpeng@iscas.ac.cn" <pengpeng@iscas.ac.cn>,
"renyanjie01@gmail.com" <renyanjie01@gmail.com>
Subject: Re: Non-existing CONFIG_ options are used in source code
Date: Fri, 1 Dec 2023 18:51:12 +0100 [thread overview]
Message-ID: <20231201185112.1499c5ab@barney> (raw)
In-Reply-To: <1553cd01-37fe-48c6-a6e3-b6ea9974d40b@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Mon, 13 Nov 2023 20:52:03 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 9/13/23 02:29, sunying@isrc.iscas.ac.cn wrote:
> > The following configuration options are not defined
> > (they may have been deleted or not yet added)
> > but are used in the source files.
> >
> > Is there something in these that might need fixing?
> >
> > ===============================================
> > 1. CONFIG_NETFS_DEBUG
> > fs/netfs/internal.h:122:#elif defined(CONFIG_NETFS_DEBUG)
> >
> > 2. CONFIG_SSB_DEBUG
> > include/linux/ssb/ssb.h:626:#ifdef CONFIG_SSB_DEBUG
> >
> > 3. CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > drivers/crypto/aspeed/aspeed-hace-crypto.c:19:#ifdef
> > CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > ===============================================
>
> Yes, please send separate patches to remove each of them.
I agree for CONFIG_SSB_DEBUG.
The function __ssb_dma_not_implemented() where CONFIG_SSB_DEBUG is used
can be removed and the switch-default where __ssb_dma_not_implemented()
is called can also be removed.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-12-01 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:29 Non-existing CONFIG_ options are used in source code sunying
2023-11-14 4:52 ` Randy Dunlap
2023-12-01 17:51 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201185112.1499c5ab@barney \
--to=m@bues.ch \
--cc=dhowells@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=pengpeng@iscas.ac.cn \
--cc=rdunlap@infradead.org \
--cc=renyanjie01@gmail.com \
--cc=sunying@isrc.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).