From: Ivan Mikhaylov <fr0st61te@gmail.com>
To: patrick@stwcx.xyz
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, peter@pjd.dev, sam@mendozajonas.com
Subject: Re: [PATCH net-next v2 3/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command
Date: Mon, 11 Dec 2023 00:53:56 +0300 [thread overview]
Message-ID: <20231210215356.4154-1-fr0st61te@gmail.com> (raw)
In-Reply-To: <20231114160737.3209218-4-patrick@stwcx.xyz>
Patrick, Peter,
> +static int ncsi_rsp_handler_gmcma(struct ncsi_request *nr)
> +{
> + struct ncsi_dev_priv *ndp = nr->ndp;
> + struct net_device *ndev = ndp->ndev.dev;
> + struct ncsi_rsp_gmcma_pkt *rsp;
> + struct sockaddr saddr;
> + int ret = -1;
> + int i;
> +
> + rsp = (struct ncsi_rsp_gmcma_pkt *)skb_network_header(nr->rsp);
> + saddr.sa_family = ndev->type;
> + ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> +
> + netdev_info(ndev, "NCSI: Received %d provisioned MAC addresses\n",
> + rsp->address_count);
> + for (i = 0; i < rsp->address_count; i++) {
> + netdev_info(ndev, "NCSI: MAC address %d: %02x:%02x:%02x:%02x:%02x:%02x\n",
> + i, rsp->addresses[i][0], rsp->addresses[i][1],
> + rsp->addresses[i][2], rsp->addresses[i][3],
> + rsp->addresses[i][4], rsp->addresses[i][5]);
> + }
> +
> + for (i = 0; i < rsp->address_count; i++) {
> + memcpy(saddr.sa_data, &rsp->addresses[i], ETH_ALEN);
> + ret = ndev->netdev_ops->ndo_set_mac_address(ndev, &saddr);
> + if (ret < 0) {
> + netdev_warn(ndev, "NCSI: Unable to assign %pM to device\n",
> + saddr.sa_data);
> + continue;
> + }
> + netdev_warn(ndev, "NCSI: Set MAC address to %pM\n", saddr.sa_data);
> + break;
> + }
> +
> + ndp->gma_flag = ret == 0;
> + return ret;
> +}
seems very similar to ncsi_rsp_handler_oem_gma except address_count, why it
shouldn't be part of this call with additional param? What's inside it just
code duplicity of ncsi_rsp_handler_oem_gma.
And as we talked in openbmc mailing list, ndo_set_mac_address do not notify
network layer about mac change and this fixed part already in
ncsi_rsp_handler_oem_gma with 790071347a0a1a89e618eedcd51c687ea783aeb3 .
David, any actions should be needed about fixing it in net-next? Need it to
put patch above with fix or do the revert from net-next and make it right?
Thanks.
next prev parent reply other threads:[~2023-12-10 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 16:07 [PATCH net-next v2 0/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command Patrick Williams
2023-11-14 16:07 ` [PATCH net-next v2 1/3] net/ncsi: Simplify Kconfig/dts control flow Patrick Williams
2023-11-14 16:07 ` [PATCH net-next v2 2/3] net/ncsi: Fix netlink major/minor version numbers Patrick Williams
2023-11-14 16:07 ` [PATCH net-next v2 3/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command Patrick Williams
2023-12-10 21:53 ` Ivan Mikhaylov [this message]
2023-12-11 2:50 ` Patrick Williams
2023-12-11 16:51 ` Jakub Kicinski
2023-11-18 15:10 ` [PATCH net-next v2 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231210215356.4154-1-fr0st61te@gmail.com \
--to=fr0st61te@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patrick@stwcx.xyz \
--cc=peter@pjd.dev \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).