From: kernel test robot <lkp@intel.com>
To: Amitesh Singh <singh.amitesh@gmail.com>, Pavel Machek <pavel@ucw.cz>
Cc: oe-kbuild-all@lists.linux.dev, Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] feat(kernel/pca963x): implement power management
Date: Mon, 11 Dec 2023 06:37:09 +0800 [thread overview]
Message-ID: <202312110656.twrTxNHo-lkp@intel.com> (raw)
In-Reply-To: <881c6ba1-1701-41be-a4ac-81cdca5f0eea@gmail.com>
Hi Amitesh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on linus/master v6.7-rc4 next-20231208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Amitesh-Singh/feat-kernel-pca963x-implement-power-management/20231210-194846
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link: https://lore.kernel.org/r/881c6ba1-1701-41be-a4ac-81cdca5f0eea%40gmail.com
patch subject: [PATCH] feat(kernel/pca963x): implement power management
config: arc-randconfig-002-20231211 (https://download.01.org/0day-ci/archive/20231211/202312110656.twrTxNHo-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231211/202312110656.twrTxNHo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312110656.twrTxNHo-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/leds/leds-pca963x.c:399:12: warning: 'pca963x_resume' defined but not used [-Wunused-function]
399 | static int pca963x_resume(struct device *dev)
| ^~~~~~~~~~~~~~
>> drivers/leds/leds-pca963x.c:385:12: warning: 'pca963x_suspend' defined but not used [-Wunused-function]
385 | static int pca963x_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~
vim +/pca963x_resume +399 drivers/leds/leds-pca963x.c
383
384 #ifdef CONFIG_PM
> 385 static int pca963x_suspend(struct device *dev)
386 {
387 struct pca963x *chip;
388 u8 reg;
389
390 chip = dev_get_drvdata(dev);
391
392 reg = i2c_smbus_read_byte_data(chip->client, PCA963X_MODE1);
393 reg = reg | (1 << PCA963X_MODE1_SLEEP);
394 i2c_smbus_write_byte_data(chip->client, PCA963X_MODE1, reg);
395
396 return 0;
397 }
398
> 399 static int pca963x_resume(struct device *dev)
400 {
401 struct pca963x *chip;
402 u8 reg;
403
404 chip = dev_get_drvdata(dev);
405
406 reg = i2c_smbus_read_byte_data(chip->client, PCA963X_MODE1);
407 reg = reg & ~(1 << PCA963X_MODE1_SLEEP);
408 i2c_smbus_write_byte_data(chip->client, PCA963X_MODE1, reg);
409
410 return 0;
411 }
412
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-12-10 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 11:46 [PATCH] feat(kernel/pca963x): implement power management Amitesh Singh
2023-12-10 22:37 ` kernel test robot [this message]
2023-12-13 11:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312110656.twrTxNHo-lkp@intel.com \
--to=lkp@intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pavel@ucw.cz \
--cc=singh.amitesh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).