From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 900A4C4167B
	for <linux-kernel@archiver.kernel.org>; Mon, 11 Dec 2023 16:51:44 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344899AbjLKQvg (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 11 Dec 2023 11:51:36 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46374 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229625AbjLKQve (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2023 11:51:34 -0500
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4DC8E
        for <linux-kernel@vger.kernel.org>; Mon, 11 Dec 2023 08:51:41 -0800 (PST)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D840C433C8;
        Mon, 11 Dec 2023 16:51:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1702313501;
        bh=jXrfnDnXSAdCkJtLjpJCKDrNg7DOIOOclITycj8SrBs=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=XvrINhKbpjF5SAY9B9Ur5XIGWUrWK005J4+6zhivTUVERjJN0CYBnXNG6sktJZBEa
         +TKtwkIzZVvPI/ygufXQWweLn+Mlqk6IeALZRk1vekCm+1e8XBBdoXTor6Yv7ivWhQ
         eL54cJKPGd8ozXq1KoU/98JRmzw28WQfqH+5QfPPpHimLkTDrn2qc37M5hhAd/CYgR
         LT1RJwRU6R4F1wu0CIRg9sztDfGXp0nQkO6lpE5eldTKmGpQmfO32z1+P/M7GeB6pF
         aL8ZWXSw25SVWwVnRbrBW4SgnRh5pKeQrIlqCEeUczOF1wijqzJZHLuNJgDRQirWa0
         gJHZU4dYAQ6pA==
Date:   Mon, 11 Dec 2023 08:51:39 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Patrick Williams <patrick@stwcx.xyz>
Cc:     Ivan Mikhaylov <fr0st61te@gmail.com>, davem@davemloft.net,
        edumazet@google.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, pabeni@redhat.com, peter@pjd.dev,
        sam@mendozajonas.com
Subject: Re: [PATCH net-next v2 3/3] net/ncsi: Add NC-SI 1.2 Get MC MAC
 Address command
Message-ID: <20231211085139.011f650a@kernel.org>
In-Reply-To: <ZXZ5EOSJAekCiT44@heinlein.vulture-banana.ts.net>
References: <20231114160737.3209218-4-patrick@stwcx.xyz>
        <20231210215356.4154-1-fr0st61te@gmail.com>
        <ZXZ5EOSJAekCiT44@heinlein.vulture-banana.ts.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 10 Dec 2023 20:50:56 -0600 Patrick Williams wrote:
> Either you or I can send a "Fixes: " on this commit to improve the
> handling as you're proposing.  While the change is likely trivial, I
> have not had any chance to test it yet, so I've not sent it up myself.
> If you want to refactor the code to reduce duplication, I think that should
> be an entirely separate proposal.

Yes, incremental change is better.