From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Cc: adamg@pobox.com
Subject: [PATCH 0/8] firewire: core: support legacy layout of configuration ROM for AV/C device
Date: Wed, 20 Dec 2023 13:17:58 +0900 [thread overview]
Message-ID: <20231220041806.39816-1-o-takashi@sakamocchi.jp> (raw)
Hi,
This series of change is to update my previous post for RFC[1], and for
merge.
Current core function of Linux FireWire subsystem has support for legacy
layout of configuration ROM, described in annex of 1394TA document[2].
However, in a point of device attributes (e.g. nodes in sysfs), there
are differences between devices with the legacy and standard layout of
configuration ROM. The differences bring some inconveniences to users[3].
The series includes changes to solve them.
The series includes changes relevant to driver matching procedure and
notification to user space, thus could easily bring functional regression.
For safe, the series includes some KUnit applications to test the change.
However, backward incompatibility is inevitable due to change of modalias
for device corresponding to unit. As long as I investigated, any unit
drivers in kernel are not affected by the change. Additionally, less
applications in user space are not as well. I think we can be optimistic
to the regression.
Changes from RFC:
* rename file and KUnit tests so that they are related to device
attributes
* fix traverse failure when detecting textual descriptor
* remove redundant indication for CSR key type
[1] [RFC PATCH 0/8] firewire: core: support legacy layout of configuration
ROM for AV/C device
https://lore.kernel.org/lkml/20231217103012.41273-1-o-takashi@sakamocchi.jp/
[2] Configuration ROM for AV/C Devices 1.0 (December 12, 2000, 1394
Trading Association, TA Document 1999027)
https://web.archive.org/web/20210216003030/http://1394ta.org/wp-content/uploads/2015/07/1999027.pdf
[3] [PATCH] Fix missing sysfs vendor/model entries for some devices
https://sourceforge.net/p/linux1394/mailman/message/55802731/
Takashi Sakamoto (8):
firewire: core: adds constant qualifier for local helper functions
firewire: core: replace magic number with macro
firewire: test: add KUnit test for device attributes
firewire: test: add test of device attributes for simple AV/C device
firewire: test: add test of device attributes for legacy AV/C device
firewire: core: detect numeric model identifier for legacy layout of
configuration ROM
firewire: core: detect model name for legacy layout of configuration
ROM
firewire: core: change modalias of unit device with backward
incompatibility
drivers/firewire/.kunitconfig | 1 +
drivers/firewire/Kconfig | 16 ++
drivers/firewire/core-device.c | 127 +++++++++---
drivers/firewire/device-attribute-test.c | 251 +++++++++++++++++++++++
4 files changed, 368 insertions(+), 27 deletions(-)
create mode 100644 drivers/firewire/device-attribute-test.c
--
2.39.2
next reply other threads:[~2023-12-20 4:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 4:17 Takashi Sakamoto [this message]
2023-12-20 4:17 ` [PATCH 1/8] firewire: core: adds constant qualifier for local helper functions Takashi Sakamoto
2023-12-20 4:18 ` [PATCH 2/8] firewire: core: replace magic number with macro Takashi Sakamoto
2023-12-20 4:18 ` [PATCH 3/8] firewire: test: add KUnit test for device attributes Takashi Sakamoto
2023-12-20 4:18 ` [PATCH 4/8] firewire: test: add test of device attributes for simple AV/C device Takashi Sakamoto
2023-12-20 4:18 ` [PATCH 5/8] firewire: test: add test of device attributes for legacy " Takashi Sakamoto
2023-12-20 4:18 ` [PATCH 6/8] firewire: core: detect numeric model identifier for legacy layout of configuration ROM Takashi Sakamoto
2023-12-20 4:18 ` [PATCH 7/8] firewire: core: detect model name " Takashi Sakamoto
2023-12-21 12:50 ` Adam Goldman
2023-12-21 13:12 ` Takashi Sakamoto
2023-12-20 4:18 ` [PATCH 8/8] firewire: core: change modalias of unit device with backward incompatibility Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220041806.39816-1-o-takashi@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=adamg@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).