From: Leo Yan <leo.yan@linaro.org>
To: Ruidong Tian <tianruidong@linux.alibaba.com>
Cc: James Clark <james.clark@arm.com>,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
suzuki.poulose@arm.com, mike.leach@linaro.org,
alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org, adrian.hunter@intel.com,
linux-perf-users@vger.kernel.org, al.grant@arm.com,
mathieu.poirier@linaro.org, tor@ti.com, acme@redhat.com
Subject: Re: [PATCH 1/3] perf scripts python: arm-cs-trace-disasm.py: print dso base address
Date: Sun, 24 Dec 2023 16:33:32 +0800 [thread overview]
Message-ID: <20231224083332.GB13521@leoy-huanghe.lan> (raw)
In-Reply-To: <6177beec-f140-44aa-b534-182cd4b0a988@linux.alibaba.com>
Hi Ruidong,
On Fri, Dec 22, 2023 at 03:29:18PM +0800, Ruidong Tian wrote:
[...]
> > Although it's also not that clear what this is useful for, given that
> > all the other output is relative too? Maybe you could add an example to
> > the commit message, even if it's just for debugging. Would an option
> > that turned _all_ the output into virtual addresses not be more useful?
>
> I want to use arm-cs-trace-disasm.py output associate with PMU and SPE data
> to explore more CPU performance info, all the PMU/SPE/Coresight informations
> generated by `perf report` and `perf script` include virtual address, so i
> want this script do the same thing.
I think James' suggestion is valid for replacing all offsets with
virtual addresses, in addition to introducing a new option.
Below change works well at my side. Hope this is helpful.
diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py
index de58991c78bb..6c94ff2287cd 100755
--- a/tools/perf/scripts/python/arm-cs-trace-disasm.py
+++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py
@@ -36,7 +36,10 @@ option_list = [
help="Set path to objdump executable file"),
make_option("-v", "--verbose", dest="verbose",
action="store_true", default=False,
- help="Enable debugging log")
+ help="Enable debugging log"),
+ make_option("-a", "--vaddr", dest="vaddr",
+ action="store_true", default=False,
+ help="Enable virtual address")
]
parser = OptionParser(option_list=option_list)
@@ -108,6 +111,14 @@ def print_disam(dso_fname, dso_start, start_addr, stop_addr):
m = disasm_re.search(line)
if m is None:
continue
+
+ # Replace offset with virtual address
+ if (options.vaddr == True):
+ offset = re.search(r"^\s*([0-9a-fA-F]+)", line).group()
+ if offset:
+ virt_addr = dso_start + int(offset, 16)
+ line = line.replace(offset.lstrip(), "0x%016x" % virt_addr)
+
print("\t" + line)
def print_sample(sample):
Thanks,
Leo
next prev parent reply other threads:[~2023-12-24 8:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 12:33 [PATCH 0/3] perf scripts python: arm-cs-trace-disasm.py: Ruidong Tian
2023-12-14 12:33 ` [PATCH 1/3] perf scripts python: arm-cs-trace-disasm.py: print dso base address Ruidong Tian
2023-12-20 10:44 ` James Clark
2023-12-22 7:29 ` Ruidong Tian
2023-12-24 8:33 ` Leo Yan [this message]
2023-12-14 12:33 ` [PATCH 2/3] perf scripts python: arm-cs-trace-disasm.py: set start vm addr of exectable file to 0 Ruidong Tian
2023-12-20 12:06 ` James Clark
2023-12-14 12:33 ` [PATCH 3/3] perf scripts python: arm-cs-trace-disasm.py: do not ignore disam first sample Ruidong Tian
2023-12-18 20:28 ` Arnaldo Carvalho de Melo
2023-12-20 11:15 ` James Clark
2023-12-20 17:31 ` [PATCH 0/3] perf scripts python: arm-cs-trace-disasm.py: Arnaldo Carvalho de Melo
2024-01-10 2:56 ` [PATCH v2 0/1] perf scripts python: arm-cs-trace-disasm.py: print correct disasm info Ruidong Tian
2024-01-10 2:56 ` [PATCH v2 1/1] perf scripts python: arm-cs-trace-disasm.py: add option to print virtual address Ruidong Tian
2024-01-10 12:55 ` Leo Yan
2024-01-10 13:48 ` Ruidong Tian
2024-01-16 2:08 ` [PATCH v3 0/1] perf scripts python: arm-cs-trace-disasm.py: print correct disasm info Ruidong Tian
2024-01-16 2:08 ` [PATCH v3 1/1] perf scripts python: arm-cs-trace-disasm.py: add option to print virtual address Ruidong Tian
2024-01-17 10:16 ` James Clark
2024-01-16 2:08 ` [PATCH v3 2/3] perf scripts python: arm-cs-trace-disasm.py: set start vm addr of exectable file to 0 Ruidong Tian
2024-01-17 10:12 ` James Clark
2024-01-16 2:08 ` Ruidong Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224083332.GB13521@leoy-huanghe.lan \
--to=leo.yan@linaro.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tianruidong@linux.alibaba.com \
--cc=tor@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).