From: Jan Kara <jack@suse.cz>
To: syzbot <syzbot+062317ea1d0a6d5e29e7@syzkaller.appspotmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
axboe@kernel.dk, chao@kernel.org, christian@brauner.io,
daniel.vetter@ffwll.ch, hch@lst.de, hdanton@sina.com,
jack@suse.cz, jaegeuk@kernel.org, jinpu.wang@ionos.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
mairacanal@riseup.net, mcanal@igalia.com,
reiserfs-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
terrelln@fb.com, willy@infradead.org, yukuai3@huawei.com
Subject: Re: [syzbot] [reiserfs?] possible deadlock in super_lock
Date: Tue, 2 Jan 2024 13:14:58 +0100 [thread overview]
Message-ID: <20240102121458.bcnwj3g4hr6xhimt@quack3> (raw)
In-Reply-To: <20231228-arterien-nachmachen-d74aec52820e@brauner>
On Thu 28-12-23 11:50:32, Christian Brauner wrote:
> On Sun, Dec 24, 2023 at 08:40:05AM -0800, syzbot wrote:
> > syzbot suspects this issue was fixed by commit:
> >
> > commit fd1464105cb37a3b50a72c1d2902e97a71950af8
> > Author: Jan Kara <jack@suse.cz>
> > Date: Wed Oct 18 15:29:24 2023 +0000
> >
> > fs: Avoid grabbing sb->s_umount under bdev->bd_holder_lock
> >
> > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14639595e80000
> > start commit: 2cf0f7156238 Merge tag 'nfs-for-6.6-2' of git://git.linux-..
> > git tree: upstream
> > kernel config: https://syzkaller.appspot.com/x/.config?x=710dc49bece494df
> > dashboard link: https://syzkaller.appspot.com/bug?extid=062317ea1d0a6d5e29e7
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=107e9518680000
> >
> > If the result looks correct, please mark the issue as fixed by replying with:
> >
> > #syz fix: fs: Avoid grabbing sb->s_umount under bdev->bd_holder_lock
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
> Fwiw, this was always a false-positive. But we also reworked the locking
> that even the false-positive cannot be triggered anymore. So yay!
Yup, nice. I think you need to start the line with syz command so:
#syz fix: fs: Avoid grabbing sb->s_umount under bdev->bd_holder_lock
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-01-02 12:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 22:30 [syzbot] [f2fs?] possible deadlock in super_lock syzbot
2023-09-20 9:13 ` [syzbot] [reiserfs?] " syzbot
2023-10-08 15:14 ` syzbot
2023-10-09 2:05 ` syzbot
2023-10-09 12:37 ` Christian Brauner
2023-10-09 14:19 ` syzbot
2023-12-24 16:40 ` syzbot
2023-12-28 10:50 ` Christian Brauner
2024-01-02 12:14 ` Jan Kara [this message]
[not found] <20230921111321.181-1-hdanton@sina.com>
2023-09-21 11:33 ` syzbot
[not found] <20230922124125.240-1-hdanton@sina.com>
2023-09-22 13:11 ` syzbot
[not found] <20230923010437.297-1-hdanton@sina.com>
2023-09-23 1:14 ` syzbot
[not found] <20230923024635.1249-1-hdanton@sina.com>
2023-09-23 3:02 ` syzbot
[not found] <20230923040320.1384-1-hdanton@sina.com>
2023-09-23 4:26 ` syzbot
[not found] <20231009112906.2143-1-hdanton@sina.com>
2023-10-09 14:01 ` syzbot
[not found] <20231010111343.2257-1-hdanton@sina.com>
2023-10-10 11:49 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102121458.bcnwj3g4hr6xhimt@quack3 \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=christian@brauner.io \
--cc=daniel.vetter@ffwll.ch \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=jaegeuk@kernel.org \
--cc=jinpu.wang@ionos.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mairacanal@riseup.net \
--cc=mcanal@igalia.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=syzbot+062317ea1d0a6d5e29e7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=terrelln@fb.com \
--cc=willy@infradead.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).