From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, andrew@lunn.ch,
edumazet@google.com, pabeni@redhat.com,
linux-arm-kernel@lists.infradead.org,
christophe.leroy@csgroup.eu, herve.codina@bootlin.com,
hkallweit1@gmail.com, vladimir.oltean@nxp.com,
kory.maincent@bootlin.com, jesse.brandeburg@intel.com,
corbet@lwn.net, kabel@kernel.org, piergiorgio.beruto@gmail.com,
o.rempel@pengutronix.de, nicveronese@gmail.com, horms@kernel.org
Subject: Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking
Date: Thu, 4 Jan 2024 16:56:09 -0800 [thread overview]
Message-ID: <20240104165609.5a56cac1@kernel.org> (raw)
In-Reply-To: <1447ce09-f90e-4ba2-a6f7-e5cb23bf724f@gmail.com>
On Thu, 4 Jan 2024 15:50:40 -0800 Florian Fainelli wrote:
> > The netlink handling looks a bit wobbly to me.
> > I commented best I could in the 20min I had to look at this code :(
> > I think it'd be best to revert, if you don't mind, because reviewing
> > incremental fixes will get even harder.
>
> +1
Okay, let's say that the three of us - Florian, Russell
and I are a quorum? :) Reverted.
next prev parent reply other threads:[~2024-01-05 0:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 18:00 [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 01/13] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-01-04 23:12 ` Jakub Kicinski
2024-01-05 2:21 ` Andrew Lunn
2024-01-05 9:29 ` Maxime Chevallier
2024-01-05 15:34 ` Jakub Kicinski
2023-12-21 18:00 ` [PATCH net-next v5 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-01-03 15:20 ` Russell King (Oracle)
2024-01-03 17:45 ` Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 04/13] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 05/13] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-01-04 23:15 ` Jakub Kicinski
2024-01-05 9:30 ` Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 06/13] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-01-04 23:34 ` Jakub Kicinski
2024-01-05 9:43 ` Maxime Chevallier
2024-01-05 13:17 ` Andrew Lunn
2024-01-24 13:50 ` Maxime Chevallier
2024-01-24 16:54 ` Andrew Lunn
2024-01-25 8:22 ` Maxime Chevallier
2024-01-25 17:10 ` Andrew Lunn
2024-01-05 15:39 ` Jakub Kicinski
2023-12-21 18:00 ` [PATCH net-next v5 08/13] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 09/13] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 10/13] net: ethtool: pse-pd: " Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 11/13] net: ethtool: cable-test: " Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 12/13] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2023-12-21 18:00 ` [PATCH net-next v5 13/13] Documentation: networking: document phy_link_topology Maxime Chevallier
2024-01-01 18:40 ` [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking patchwork-bot+netdevbpf
2024-01-02 11:57 ` Russell King (Oracle)
2024-01-02 18:51 ` Jakub Kicinski
2024-01-03 14:33 ` Maxime Chevallier
2024-01-04 23:47 ` Jakub Kicinski
2024-01-04 23:50 ` Florian Fainelli
2024-01-05 0:56 ` Jakub Kicinski [this message]
2024-01-05 9:00 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104165609.5a56cac1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=piergiorgio.beruto@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).