From: Lee Jones <lee@kernel.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
fuyao <fuyao1697@cyg.com>, Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>,
maijianzhang <maijianzhang@allwinnertech.com>
Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number
Date: Tue, 9 Jan 2024 08:55:57 +0000 [thread overview]
Message-ID: <20240109085557.GG7948@google.com> (raw)
In-Reply-To: <4953611.0VBMTVartN@jernej-laptop>
On Fri, 22 Dec 2023, Jernej Škrabec wrote:
> Dne četrtek, 21. december 2023 ob 16:25:53 CET je Lee Jones napisal(a):
> > On Wed, 20 Dec 2023, Andre Przywara wrote:
> >
> > > On Wed, 20 Dec 2023 15:23:17 +0800
> > > fuyao <fuyao1697@cyg.com> wrote:
> > >
> > > Hi,
> > >
> > > > __platform_get_irq_byname determinies whether the interrupt
> > > > number is 0 and returns EINVAL.
> > >
> > > can you please say what this fixes, exactly? Is something not working at
> > > the moment? Can you please provide parts of the error message?
> > >
> > > And maybe expand the explanation a bit more? For instance mention that the
> > > identifiers are used as IRQ resource numbers, where 0 is treated specially.
> > >
> > > Cheers,
> > > Andre
> > >
> > > >
> > > > Signed-off-by: fuyao <fuyao1697@cyg.com>
> >
> > You have to use your full real name as well.
>
> Isn't that enough after
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 ?
I believe that change in stance is to be more accepting of people who
are universally known by their pseudonyms, like Tixy, Wookey or Piglet,
to name a few that I'm aware of. If fuyao is universally known by that
name then sure, it's enough. It just doesn't look very name-like in its
current guise, due to the shortness and lack of capitalisation. It
looks to me more like a username, which is not as generally acceptable
AFAIA.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-01-09 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:47 [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number fuyao
2022-08-25 20:18 ` Jernej Škrabec
2022-09-08 6:55 ` Lee Jones
2023-12-20 7:15 ` [PATCH RESEND] " fuyao
2023-12-20 7:23 ` fuyao
2023-12-20 11:54 ` Andre Przywara
2023-12-21 15:25 ` Lee Jones
2023-12-21 15:26 ` Lee Jones
2023-12-22 17:54 ` Jernej Škrabec
2023-12-25 9:54 ` fuyao
2024-01-09 8:55 ` Lee Jones [this message]
2023-12-25 9:52 ` fuyao
2023-12-20 7:08 ` fuyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109085557.GG7948@google.com \
--to=lee@kernel.org \
--cc=andre.przywara@arm.com \
--cc=fuyao1697@cyg.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maijianzhang@allwinnertech.com \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).