From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ansuel Smith" <ansuelsmth@gmail.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] dt-bindings: mtd: partitions: make partition an NVMEM provider
Date: Fri, 19 Jan 2024 16:33:56 -0600 [thread overview]
Message-ID: <20240119223356.GA1179470-robh@kernel.org> (raw)
In-Reply-To: <20240111121940.15628-1-zajec5@gmail.com>
On Thu, Jan 11, 2024 at 01:19:40PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> MTD partition provides flash device data and can be used as NVMEM
> device.
I don't follow what is the relationship between this and your other
series.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/mtd/partitions/partition.yaml | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> index 1ebe9e2347ea..7b1d84ce5ef5 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> @@ -57,13 +57,15 @@ properties:
> user space from
> type: boolean
>
> -if:
> - not:
> - required: [ reg ]
> -then:
> - properties:
> - $nodename:
> - pattern: '^partition-.*$'
> +allOf:
> + - $ref: /schemas/nvmem/nvmem.yaml
Only some partitions are nvmem nodes, so we shouldn't always include it.
Then we can't exclude nvmem properties from partition nodes which
aren't. We should identify those nodes by compatible and their schema
should reference partition.yaml and nvmem.yaml.
There's a general problem with the partition related schemas that
undefined properties are not caught. This is partly because
partition nodes can be nested and expressing that with the schema is
hard.
Rob
prev parent reply other threads:[~2024-01-19 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 12:19 [PATCH] dt-bindings: mtd: partitions: make partition an NVMEM provider Rafał Miłecki
2024-01-11 12:26 ` Rafał Miłecki
2024-01-19 22:33 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119223356.GA1179470-robh@kernel.org \
--to=robh@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).