From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Ye Bin <yebin10@huawei.com>
Cc: <rostedt@goodmis.org>, <mathieu.desnoyers@efficios.com>,
<linux-trace-kernel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 6/7] Documentation: tracing: add new type '%pd' and '%pD' for kprobe
Date: Tue, 23 Jan 2024 22:07:32 +0900 [thread overview]
Message-ID: <20240123220732.79d810aa183b3ddfd2b2a4ab@kernel.org> (raw)
In-Reply-To: <20240123092139.3698375-7-yebin10@huawei.com>
On Tue, 23 Jan 2024 17:21:38 +0800
Ye Bin <yebin10@huawei.com> wrote:
> Similar to printk() '%pd' is for fetch dentry's name from struct dentry's
> pointer, and '%pD' is for fetch file's name from struct file's pointer.
>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> Documentation/trace/kprobetrace.rst | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst
> index bf9cecb69fc9..a1d12d65a8dc 100644
> --- a/Documentation/trace/kprobetrace.rst
> +++ b/Documentation/trace/kprobetrace.rst
> @@ -58,7 +58,8 @@ Synopsis of kprobe_events
> NAME=FETCHARG : Set NAME as the argument name of FETCHARG.
> FETCHARG:TYPE : Set TYPE as the type of FETCHARG. Currently, basic types
> (u8/u16/u32/u64/s8/s16/s32/s64), hexadecimal types
> - (x8/x16/x32/x64), "char", "string", "ustring", "symbol", "symstr"
> + (x8/x16/x32/x64), VFS layer common type(%pd/%pD) for print
> + file name, "char", "string", "ustring", "symbol", "symstr"
Could you remove the "for print file name" here? Since this is not the place
where such precise information describes. I think following hunk is enough to
explain it.
Thank you,
> and bitfield are supported.
>
> (\*1) only for the probe on function entry (offs == 0). Note, this argument access
> @@ -113,6 +114,9 @@ With 'symstr' type, you can filter the event with wildcard pattern of the
> symbols, and you don't need to solve symbol name by yourself.
> For $comm, the default type is "string"; any other type is invalid.
>
> +VFS layer common type(%pd/%pD) is a special type, which fetches dentry's or
> +file's name from struct dentry's pointer or struct file's pointer.
> +
> .. _user_mem_access:
>
> User Memory Access
> --
> 2.31.1
>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-01-23 13:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 9:21 [PATCH v4 0/7] support '%pd' and '%pD' for print file name Ye Bin
2024-01-23 9:21 ` [PATCH v4 1/7] string.h: add str_has_suffix() helper for test string ends with specify string Ye Bin
2024-01-23 9:21 ` [PATCH v4 2/7] tracing/probes: add traceprobe_expand_dentry_args() helper Ye Bin
2024-01-23 14:26 ` Masami Hiramatsu
2024-01-23 9:21 ` [PATCH v4 3/7] tracing/probes: support '%pd' type for print struct dentry's name Ye Bin
2024-01-23 14:40 ` Masami Hiramatsu
2024-01-24 2:46 ` yebin (H)
2024-01-24 12:27 ` Masami Hiramatsu
2024-01-23 9:21 ` [PATCH v4 4/7] tracing/probes: support '%pD' type for print struct file's name Ye Bin
2024-01-23 9:21 ` [PATCH v4 5/7] tracing: add new type "%pd/%pD" in readme_msg[] Ye Bin
2024-01-23 9:21 ` [PATCH v4 6/7] Documentation: tracing: add new type '%pd' and '%pD' for kprobe Ye Bin
2024-01-23 13:07 ` Masami Hiramatsu [this message]
2024-01-23 9:21 ` [PATCH v4 7/7] selftests/ftrace: add test cases for VFS type "%pd" and "%pD" Ye Bin
2024-01-24 1:32 ` Masami Hiramatsu
2024-01-24 1:53 ` yebin (H)
2024-01-24 3:21 ` yebin (H)
2024-01-24 23:30 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123220732.79d810aa183b3ddfd2b2a4ab@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).