From: Nathan Chancellor <nathan@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
llvm@lists.linux.dev, keescook@chromium.org,
arei.gonglei@huawei.com, mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux.dev, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 5.10 000/286] 5.10.209-rc1 review
Date: Fri, 26 Jan 2024 17:03:18 -0700 [thread overview]
Message-ID: <20240127000318.GA1561706@dev-arch.thelio-3990X> (raw)
In-Reply-To: <bef7737e-4b8e-4a89-b538-cd8e75874fd2@roeck-us.net>
On Fri, Jan 26, 2024 at 03:55:02PM -0800, Guenter Roeck wrote:
> Anyway, how did you find that ? Is there a magic trick to find the
> actual code causing the warning ? I am asking because we had seen
> similar warnings before, and it would help to know how to find the
> problematic code.
The easiest way I have found is figuring out what primitive is causing
the warning (memset, memcpy) then just commenting out the uses in the
particular file until the warning goes away. Sometimes it is quick like
in this case since there were only two instances of memcpy() in that
file but other cases it can definitely take time. There could be
potential issues with that approach if the problematic use is in a
header, at which point you could generate a preprocessed ('.i') file and
see where fortify_memcpy_chk() or fortify_memset_chk() come from in that
file.
Cheers,
Nathan
next prev parent reply other threads:[~2024-01-27 0:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 23:55 [PATCH 5.10 000/286] 5.10.209-rc1 review Greg Kroah-Hartman
2024-01-23 3:32 ` Dominique Martinet
2024-01-23 21:19 ` Florian Fainelli
2024-01-24 11:25 ` Naresh Kamboju
2024-01-26 16:46 ` Guenter Roeck
2024-01-26 17:51 ` Greg Kroah-Hartman
2024-01-26 18:17 ` Guenter Roeck
2024-01-26 18:48 ` Greg Kroah-Hartman
2024-01-26 20:34 ` Nathan Chancellor
2024-01-26 21:01 ` Guenter Roeck
2024-01-26 21:53 ` Greg Kroah-Hartman
2024-01-26 22:35 ` Nathan Chancellor
2024-01-26 23:55 ` Guenter Roeck
2024-01-27 0:03 ` Nathan Chancellor [this message]
2024-01-28 11:13 ` Michael S. Tsirkin
2024-01-29 8:46 ` Michael S. Tsirkin
2024-01-29 9:58 ` zhenwei pi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240127000318.GA1561706@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=mst@redhat.com \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).