From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Cc: adamg@pobox.com
Subject: [PATCH 0/2] firewire: core: optimization for the quirk of Sony DVMC-DA1
Date: Tue, 30 Jan 2024 19:04:07 +0900 [thread overview]
Message-ID: <20240130100409.30128-1-o-takashi@sakamocchi.jp> (raw)
Hi,
A quirk was reported that Sony DVMC-DA1 has a quirk in its configuration
ROM[1]. It has the legacy layout of configuration ROM[2] with the quirk
that the descriptor leaf entry locates just after the vendor directory
entry in its root directory. It is not the layout in the documentation
since the usual descriptor leaf entry locates just after the vendor
immediate entry. Current implementation of firewire-core fail to pick up
the content of descriptor leaf for vendor name.
This series of changes is to optimize for the quirk, including a slight
correction of documentation for the relevant kernel API. The changes
are written to be accepted to the release candidates of v6.8 so that
they don't conflict to the changes in for-next branch[3], thus they
do not necessarily have a good look.
[1] https://lore.kernel.org/lkml/20240126011705.GA22564@workstation.local/
[2] Configuration ROM for AV/C Devices 1.0 (1394 Trading Association, Dec
2000, TA Document 1999027)
https://web.archive.org/web/20210216003030/http://1394ta.org/wp-content/uploads/2015/07/1999027.pdf
[3] https://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git/log/?h=for-next
Takashi Sakamoto (2):
firewire: core: correct documentation of fw_csr_string() kernel API
firewire: core: search descriptor leaf just after vendor directory
entry in root directory
drivers/firewire/core-device.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
--
2.40.1
next reply other threads:[~2024-01-30 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:04 Takashi Sakamoto [this message]
2024-01-30 10:04 ` [PATCH 1/2] firewire: core: correct documentation of fw_csr_string() kernel API Takashi Sakamoto
2024-01-30 10:04 ` [PATCH 2/2] firewire: core: search descriptor leaf just after vendor directory entry in root directory Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130100409.30128-1-o-takashi@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=adamg@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).