linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elizabeth Figura <zfigura@codeweavers.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	wine-devel@winehq.org, "André Almeida" <andrealmeid@igalia.com>,
	"Wolfram Sang" <wsa@kernel.org>,
	"Arkadiusz Hiler" <ahiler@codeweavers.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Andy Lutomirski" <luto@kernel.org>,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
	"Elizabeth Figura" <zfigura@codeweavers.com>
Subject: [RFC PATCH v2 12/29] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE.
Date: Tue, 30 Jan 2024 20:13:39 -0600	[thread overview]
Message-ID: <20240131021356.10322-13-zfigura@codeweavers.com> (raw)
In-Reply-To: <20240131021356.10322-1-zfigura@codeweavers.com>

This corresponds to the NT syscall NtPulseEvent().

This wakes up any waiters as if the event had been set, but does not set the
event, instead resetting it if it had been signalled. Thus, for a manual-reset
event, all waiters are woken, whereas for an auto-reset event, at most one
waiter is woken.

Signed-off-by: Elizabeth Figura <zfigura@codeweavers.com>
---
 drivers/misc/ntsync.c       | 10 ++++++++--
 include/uapi/linux/ntsync.h |  1 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
index 009d927739b8..240ae858fa96 100644
--- a/drivers/misc/ntsync.c
+++ b/drivers/misc/ntsync.c
@@ -447,7 +447,7 @@ static int ntsync_mutex_kill(struct ntsync_obj *mutex, void __user *argp)
 	return ret;
 }
 
-static int ntsync_event_set(struct ntsync_obj *event, void __user *argp)
+static int ntsync_event_set(struct ntsync_obj *event, void __user *argp, bool pulse)
 {
 	struct ntsync_device *dev = event->dev;
 	__u32 prev_state;
@@ -463,6 +463,8 @@ static int ntsync_event_set(struct ntsync_obj *event, void __user *argp)
 		event->u.event.signaled = true;
 		try_wake_all_obj(dev, event);
 		try_wake_any_event(event);
+		if (pulse)
+			event->u.event.signaled = false;
 
 		spin_unlock(&event->lock);
 		spin_unlock(&dev->wait_all_lock);
@@ -472,6 +474,8 @@ static int ntsync_event_set(struct ntsync_obj *event, void __user *argp)
 		prev_state = event->u.event.signaled;
 		event->u.event.signaled = true;
 		try_wake_any_event(event);
+		if (pulse)
+			event->u.event.signaled = false;
 
 		spin_unlock(&event->lock);
 	}
@@ -526,9 +530,11 @@ static long ntsync_obj_ioctl(struct file *file, unsigned int cmd,
 	case NTSYNC_IOC_MUTEX_KILL:
 		return ntsync_mutex_kill(obj, argp);
 	case NTSYNC_IOC_EVENT_SET:
-		return ntsync_event_set(obj, argp);
+		return ntsync_event_set(obj, argp, false);
 	case NTSYNC_IOC_EVENT_RESET:
 		return ntsync_event_reset(obj, argp);
+	case NTSYNC_IOC_EVENT_PULSE:
+		return ntsync_event_set(obj, argp, true);
 	default:
 		return -ENOIOCTLCMD;
 	}
diff --git a/include/uapi/linux/ntsync.h b/include/uapi/linux/ntsync.h
index f2d7507d8438..598f894f868d 100644
--- a/include/uapi/linux/ntsync.h
+++ b/include/uapi/linux/ntsync.h
@@ -50,5 +50,6 @@ struct ntsync_wait_args {
 #define NTSYNC_IOC_MUTEX_KILL		_IOW ('N', 0x86, __u32)
 #define NTSYNC_IOC_EVENT_SET		_IOR ('N', 0x88, __u32)
 #define NTSYNC_IOC_EVENT_RESET		_IOR ('N', 0x89, __u32)
+#define NTSYNC_IOC_EVENT_PULSE		_IOR ('N', 0x8a, __u32)
 
 #endif
-- 
2.43.0


  parent reply	other threads:[~2024-01-31  2:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  2:13 [RFC PATCH v2 00/29] NT synchronization primitive driver Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 01/29] ntsync: Introduce the ntsync driver and character device Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 02/29] ntsync: Introduce NTSYNC_IOC_CREATE_SEM Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 03/29] ntsync: Introduce NTSYNC_IOC_SEM_POST Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 04/29] ntsync: Introduce NTSYNC_IOC_WAIT_ANY Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 05/29] ntsync: Introduce NTSYNC_IOC_WAIT_ALL Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 06/29] ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 07/29] ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 08/29] ntsync: Introduce NTSYNC_IOC_MUTEX_KILL Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 09/29] ntsync: Introduce NTSYNC_IOC_CREATE_EVENT Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 10/29] ntsync: Introduce NTSYNC_IOC_EVENT_SET Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 11/29] ntsync: Introduce NTSYNC_IOC_EVENT_RESET Elizabeth Figura
2024-01-31  2:13 ` Elizabeth Figura [this message]
2024-01-31  2:13 ` [RFC PATCH v2 13/29] ntsync: Introduce NTSYNC_IOC_SEM_READ Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 14/29] ntsync: Introduce NTSYNC_IOC_MUTEX_READ Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 15/29] ntsync: Introduce NTSYNC_IOC_EVENT_READ Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 16/29] ntsync: Introduce alertable waits Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 17/29] selftests: ntsync: Add some tests for semaphore state Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 18/29] selftests: ntsync: Add some tests for mutex state Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 19/29] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY Elizabeth Figura
2024-01-31  8:52   ` Andi Kleen
2024-02-03  2:08     ` Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 20/29] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 21/29] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 22/29] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 23/29] selftests: ntsync: Add some tests for manual-reset event state Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 24/29] selftests: ntsync: Add some tests for auto-reset " Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 25/29] selftests: ntsync: Add some tests for wakeup signaling with events Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 26/29] selftests: ntsync: Add tests for alertable waits Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 27/29] selftests: ntsync: Add some tests for wakeup signaling via alerts Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 28/29] maintainers: Add an entry for ntsync Elizabeth Figura
2024-01-31  2:13 ` [RFC PATCH v2 29/29] docs: ntsync: Add documentation for the ntsync uAPI Elizabeth Figura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131021356.10322-13-zfigura@codeweavers.com \
    --to=zfigura@codeweavers.com \
    --cc=ahiler@codeweavers.com \
    --cc=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=wine-devel@winehq.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).