From: Jason Gunthorpe <jgg@ziepe.ca>
To: Nikhil V <quic_nprakash@quicinc.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Charan Teja Kalla <quic_charante@quicinc.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu: Avoid races around default domain allocations
Date: Thu, 8 Feb 2024 12:09:32 -0400 [thread overview]
Message-ID: <20240208160932.GT31743@ziepe.ca> (raw)
In-Reply-To: <1cb6a33f-57e8-f3d0-9098-755af70cda41@quicinc.com>
On Thu, Feb 08, 2024 at 08:47:42PM +0530, Nikhil V wrote:
> Also, as Jason pointed out, this fix would not allow changing the
> default domain for an iommu group. We didn't have any usecase for
> changing default domain, hence couldn't see any issues with the fix
> proposed. So, we would have to rework the patch for it to be
> upstream ready. Any suggestions for this would be really helpful and
> appreciated. Thanks!!!
I think you can lift and duplicate the check into the callers and that
way restrict it only to the probe paths.
Jason
prev parent reply other threads:[~2024-02-08 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 10:11 [PATCH 1/1] iommu: Avoid races around default domain allocations Nikhil V
2024-01-29 7:59 ` Nikhil V
2024-02-01 16:23 ` Jason Gunthorpe
2024-02-07 14:26 ` Nikhil V
2024-02-07 14:56 ` Jason Gunthorpe
2024-02-08 0:04 ` Robin Murphy
2024-02-08 1:13 ` Jason Gunthorpe
2024-02-08 1:37 ` Robin Murphy
2024-02-08 15:17 ` Nikhil V
2024-02-08 16:09 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208160932.GT31743@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_charante@quicinc.com \
--cc=quic_nprakash@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).