Re: [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema

From: Rob Herring <robh@kernel.org>
To: Dharma.B@microchip.com
Cc: conor@kernel.org, alexandre.belloni@bootlin.com,
	conor+dt@kernel.org, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, Nicolas.Ferre@microchip.com,
	linux-arm-kernel@lists.infradead.org, claudiu.beznea@tuxon.dev,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema
Date: Fri, 9 Feb 2024 09:10:54 +0000	[thread overview]
Message-ID: <20240209091054.GA3291998-robh@kernel.org> (raw)
In-Reply-To: <8dcae60c-1aba-4e76-99cd-de78c2c4ba6a@microchip.com>

On Fri, Feb 09, 2024 at 06:31:15AM +0000, Dharma.B@microchip.com wrote:
> Hi Conor,
> 
> On 09/02/24 12:19 am, Conor Dooley wrote:
> > Hey Dharma,
> > 
> > On Thu, Feb 08, 2024 at 03:51:31PM +0000, Rob Herring wrote:
> >> On Thu, 08 Feb 2024 14:50:15 +0530, Dharma Balasubiramani wrote:
> >>> Convert the Atmel AIC binding document to DT schema format using
> >>> json-schema.
> >>>
> >>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com>
> >>> ---
> >>> Note: I get the following warnings on latest kernel but not in 6.7.
> >>> Should I be worried?
> >>> usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR [FILE_OR_DIR ...]]
> >>> yamllint: error: one of the arguments FILE_OR_DIR - is required
> > Hard to say, how were you envoking the command? There were some issues
> > recently with dt_binding_check, but I thought those had been fixed.
> 
> I use this command to validate
> 
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- dt_binding_check 
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml

Humm, not sure. Will have to investigate.

> and also dtbs_check.
> 
> version = yamllint 1.32.0
> > 
> >> dtschema/dtc warnings/errors:
> >> Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']
> > But you didn't see this warning?
> 
> No I didn't see this warning when applied on tag:6.7. Don't know why.

That's because it just got enabled by default.

> 
> > I think you can resolve it by just dropping the "user" example from the
> > binding entirely. I don't think it adds anything at all.
> 
> I intentionally checked the generated example dts file and found that 
> both the examples look correct.

Maybe so, but how do we know with no schema? Your choices are drop from 
the example or add a schema for the DMA controller.

Rob