From: Conor Dooley <conor.dooley@microchip.com>
To: Eric Chan <ericchancf@google.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb}
Date: Mon, 12 Feb 2024 08:03:44 +0000 [thread overview]
Message-ID: <20240212-projector-dangle-7815fa2f7415@wendy> (raw)
In-Reply-To: <20240209125048.4078639-1-ericchancf@google.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Fri, Feb 09, 2024 at 12:50:48PM +0000, Eric Chan wrote:
> Disparate fence implementations are consolidated into fence.h.
>
> Introduce __{mb,rmb,wmb}, and rely on the generic definitions
> for {mb,rmb,wmb}. A first consequence is that __{mb,rmb,wmb}
> map to a compiler barrier on !SMP (while their definition remains
> unchanged on SMP).
>
> Introduce RISCV_FULL_BARRIER and use in arch_atomic* function.
> like RISCV_ACQUIRE_BARRIER and RISCV_RELEASE_BARRIER, The fence
> instruction can be eliminated When SMP is not in use.
>
> Also clean up the warning with scripts/checkpatch.pl.
>
> Signed-off-by: Eric Chan <ericchancf@google.com>
In all configs:
../arch/riscv/include/asm/fence.h:7:10: error: expected expression before '__asm__'
https://patchwork.kernel.org/project/linux-riscv/patch/20240209125048.4078639-1-ericchancf@google.com/
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-02-12 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 12:50 [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb} Eric Chan
2024-02-12 8:03 ` Conor Dooley [this message]
2024-02-12 10:59 ` [PATCH v2] " Eric Chan
2024-02-13 10:38 ` Andrea Parri
2024-02-13 14:57 ` Eric Chan
2024-02-13 15:03 ` [PATCH] " Eric Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212-projector-dangle-7815fa2f7415@wendy \
--to=conor.dooley@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=ericchancf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).