linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Ojha <quic_mojha@quicinc.com>
To: <mcgrof@kernel.org>, <russ.weight@linux.dev>,
	<gregkh@linuxfoundation.org>, <rafael@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, Mukesh Ojha <quic_mojha@quicinc.com>
Subject: [PATCH vRFC 8/8] firmware: FW_OPT_UEVENT for all request_firmware family functions
Date: Thu, 22 Feb 2024 23:30:33 +0530	[thread overview]
Message-ID: <20240222180033.23775-9-quic_mojha@quicinc.com> (raw)
In-Reply-To: <20240222180033.23775-1-quic_mojha@quicinc.com>

Currently, FW_OPT_UEVENT is used in almost every request_firmware
family function apart from request_firmware_nowait(), however,
request_firmware_nowait() uses much lower level api which does
not assume FW_OPT_UEVENT to be a default flag.

Apply FW_OPT_UEVENT as default flag.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
 drivers/base/firmware_loader/main.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index 91a45767a3a7..4650fef9b713 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -985,7 +985,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 
 	/* Need to pin this module until return */
 	__module_get(THIS_MODULE);
-	ret = __request_firmware(firmware_p, name, device, NULL, 0, 0, opt_flags);
+	ret = __request_firmware(firmware_p, name, device, NULL, 0, 0,
+				 FW_OPT_UEVENT | opt_flags);
 	module_put(THIS_MODULE);
 	return ret;
 }
@@ -1013,8 +1014,7 @@ int
 request_firmware(const struct firmware **firmware_p, const char *name,
 		 struct device *device)
 {
-	return _request_firmware(firmware_p, name, device, NULL, 0, 0,
-				 FW_OPT_UEVENT);
+	return _request_firmware(firmware_p, name, device, NULL, 0, 0, 0);
 }
 EXPORT_SYMBOL(request_firmware);
 
@@ -1034,8 +1034,7 @@ EXPORT_SYMBOL(request_firmware);
 int request_firmware_nowarn(const struct firmware **firmware, const char *name,
 			    struct device *device)
 {
-	return _request_firmware(firmware, name, device, NULL, 0, 0,
-				 FW_OPT_UEVENT | FW_OPT_NO_WARN);
+	return _request_firmware(firmware, name, device, NULL, 0, 0, FW_OPT_NO_WARN);
 }
 EXPORT_SYMBOL_GPL(request_firmware_nowarn);
 
@@ -1054,8 +1053,7 @@ int request_firmware_direct(const struct firmware **firmware_p,
 			    const char *name, struct device *device)
 {
 	return _request_firmware(firmware_p, name, device, NULL, 0, 0,
-				 FW_OPT_UEVENT | FW_OPT_NO_WARN |
-				 FW_OPT_NOFALLBACK_SYSFS);
+				 FW_OPT_NO_WARN | FW_OPT_NOFALLBACK_SYSFS);
 }
 EXPORT_SYMBOL_GPL(request_firmware_direct);
 
@@ -1073,7 +1071,7 @@ int request_firmware_platform(const struct firmware **firmware,
 			      const char *name, struct device *device)
 {
 	return _request_firmware(firmware, name, device, NULL, 0, 0,
-				 FW_OPT_UEVENT | FW_OPT_FALLBACK_PLATFORM);
+				 FW_OPT_FALLBACK_PLATFORM);
 }
 EXPORT_SYMBOL_GPL(request_firmware_platform);
 
@@ -1124,7 +1122,7 @@ request_firmware_into_buf(const struct firmware **firmware_p, const char *name,
 		return -EOPNOTSUPP;
 
 	return _request_firmware(firmware_p, name, device, buf, size, 0,
-				 FW_OPT_UEVENT | FW_OPT_NOCACHE);
+				 FW_OPT_NOCACHE);
 }
 EXPORT_SYMBOL(request_firmware_into_buf);
 
@@ -1149,8 +1147,7 @@ request_partial_firmware_into_buf(const struct firmware **firmware_p,
 		return -EOPNOTSUPP;
 
 	return _request_firmware(firmware_p, name, device, buf, size, offset,
-				 FW_OPT_UEVENT | FW_OPT_NOCACHE |
-				 FW_OPT_PARTIAL);
+				 FW_OPT_NOCACHE | FW_OPT_PARTIAL);
 }
 EXPORT_SYMBOL(request_partial_firmware_into_buf);
 
-- 
2.43.0.254.ga26002b62827


      parent reply	other threads:[~2024-02-22 18:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 18:00 [PATCH vRFC 0/8] Refactor and rename request firmware API Mukesh Ojha
2024-02-22 18:00 ` [PATCH vRFC 1/8] firmware_loader: Refactor request firmware lower level functions Mukesh Ojha
2024-02-22 18:00 ` [PATCH vRFC 2/8] treewide: rename firmware_request_nowarn() Mukesh Ojha
2024-02-22 18:00 ` [PATCH vRFC 3/8] treewide: rename firmware_request_platform() Mukesh Ojha
2024-02-23  6:21   ` Greg KH
2024-02-23 15:15     ` Luis Chamberlain
2024-02-23 15:33       ` Greg KH
2024-02-23 19:42         ` Luis Chamberlain
2024-02-24  5:36           ` Greg KH
2024-02-26 10:52             ` Mukesh Ojha
2024-02-26 13:09               ` Greg KH
2024-02-26 13:22                 ` Mukesh Ojha
2024-02-26 16:06                   ` Luis Chamberlain
2024-02-22 18:00 ` [PATCH vRFC 4/8] treewide: rename firmware_request_cache() Mukesh Ojha
2024-02-22 18:00 ` [PATCH vRFC 5/8] firmware: Convert minor inline function to macro Mukesh Ojha
2024-02-23  6:22   ` Greg KH
2024-02-22 18:00 ` [PATCH vRFC 6/8] firmware: Move module template to the bottom Mukesh Ojha
2024-02-22 18:00 ` [PATCH vRFC 7/8] firmware: remove prototype of fw_cache_piggyback_on_request() Mukesh Ojha
2024-02-22 18:00 ` Mukesh Ojha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222180033.23775-9-quic_mojha@quicinc.com \
    --to=quic_mojha@quicinc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=rafael@kernel.org \
    --cc=russ.weight@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).