Re: [PATCH v3 1/3] dt-bindings: power: supply: Add Acer Aspire 1 EC

From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Nikita Travkin <nikita@trvn.ru>,
	Sebastian Reichel <sre@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	cros-qcom-dts-watchers@chromium.org,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: power: supply: Add Acer Aspire 1 EC
Date: Thu, 22 Feb 2024 21:56:37 -0700	[thread overview]
Message-ID: <20240223045637.GA3983053-robh@kernel.org> (raw)
In-Reply-To: <20240220-splinter-jackpot-ac1571af5b2d@spud>

On Tue, Feb 20, 2024 at 06:41:06PM +0000, Conor Dooley wrote:
> Rob,
> 
> On Tue, Feb 20, 2024 at 04:57:12PM +0500, Nikita Travkin wrote:
> > Add binding for the EC found in the Acer Aspire 1 laptop.
> > 
> > Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> > ---
> >  .../bindings/power/supply/acer,aspire1-ec.yaml     | 69 ++++++++++++++++++++++
> >  1 file changed, 69 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/power/supply/acer,aspire1-ec.yaml b/Documentation/devicetree/bindings/power/supply/acer,aspire1-ec.yaml
> > new file mode 100644
> > index 000000000000..984cf19cf806
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/acer,aspire1-ec.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/acer,aspire1-ec.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Acer Aspire 1 Embedded Controller
> > +
> > +maintainers:
> > +  - Nikita Travkin <nikita@trvn.ru>
> > +
> > +description:
> > +  The Acer Aspire 1 laptop uses an embedded controller to control battery
> > +  and charging as well as to provide a set of misc features such as the
> > +  laptop lid status and HPD events for the USB Type-C DP alt mode.
> > +
> > +properties:
> > +  compatible:
> > +    const: acer,aspire1-ec
> > +
> > +  reg:
> > +    const: 0x76
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  acer,fn-selects-media-keys:
> > +    description: Configure the keyboard layout to invert the Fn key.
> > +      By default the function row of the keyboard inputs media keys
> > +      (i.e Vol-Up) when Fn is not pressed. With this option set, pressing
> > +      the key without Fn would input function keys (i.e. F11). The
> > +      firmware may choose to add this property when user selects the fn
> > +      mode in the firmware setup utility.
> > +    type: boolean
> 
> We both had some comments on this property, and Nikita tried to follow
> up on yours (which was much more substantive than mine) but got no
> response:
> https://lore.kernel.org/all/20231214220210.GA988134-robh@kernel.org/
> 
> Reading what you said, I'm not entirely sure what you were looking for,
> my guess is that you were wanted something controllable from userspace,
> but I'm not sure how you figured that should work where the firmware
> alone is able to control this.

I replied there, but what I want is whatever the solution is to work on 
any laptop, not just this Acer device.

Rob