From: Bhargav Raviprakash <bhargav.r@ltts.com>
To: linux-kernel@vger.kernel.org
Cc: m.nirmaladevi@ltts.com, lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jpanis@baylibre.com, devicetree@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, lgirdwood@gmail.com,
broonie@kernel.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
nm@ti.com, vigneshr@ti.com, kristo@kernel.org,
Bhargav Raviprakash <bhargav.r@ltts.com>
Subject: [PATCH v2 09/14] misc: tps6594-esm: reversion check limited to TPS6594 family
Date: Fri, 23 Feb 2024 15:06:56 +0530 [thread overview]
Message-ID: <20240223093701.66034-10-bhargav.r@ltts.com> (raw)
In-Reply-To: <20240223093701.66034-1-bhargav.r@ltts.com>
The reversion check is only applicable on TPS6594 family of PMICs.
Conditionally add that check if the chip_id is one of the PMIC in
the TPS6594 family.
Signed-off-by: Bhargav Raviprakash <bhargav.r@ltts.com>
---
drivers/misc/tps6594-esm.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c
index b4d67a1a2..8ec5af9dc 100644
--- a/drivers/misc/tps6594-esm.c
+++ b/drivers/misc/tps6594-esm.c
@@ -45,13 +45,17 @@ static int tps6594_esm_probe(struct platform_device *pdev)
* As a consequence, ESM can not be used on those PMIC.
* Check the version and return an error in case of revision 1.
*/
- ret = regmap_read(tps->regmap, TPS6594_REG_DEV_REV, &rev);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to read PMIC revision\n");
- if (rev == TPS6594_DEV_REV_1)
- return dev_err_probe(dev, -ENODEV,
- "ESM not supported for revision 1 PMIC\n");
+ if (tps->chip_id == TPS6594 ||
+ tps->chip_id == TPS6593 ||
+ tps->chip_id == LP8764) {
+ ret = regmap_read(tps->regmap, TPS6594_REG_DEV_REV, &rev);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "Failed to read PMIC revision\n");
+ if (rev == TPS6594_DEV_REV_1)
+ return dev_err_probe(dev, -ENODEV,
+ "ESM not supported for revision 1 PMIC\n");
+ }
for (i = 0; i < pdev->num_resources; i++) {
irq = platform_get_irq_byname(pdev, pdev->resource[i].name);
--
2.25.1
next prev parent reply other threads:[~2024-02-23 9:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 9:36 [PATCH v2 00/14] Add support for TI TPS65224 PMIC Bhargav Raviprakash
2024-02-23 9:36 ` [PATCH v2 01/14] mfd: tps6594: Add register definitions " Bhargav Raviprakash
2024-02-26 11:07 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 02/14] mfd: tps6594: use volatile_table instead of volatile_reg Bhargav Raviprakash
2024-02-26 11:15 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 03/14] mfd: tps6594: add regmap config in match data Bhargav Raviprakash
2024-02-26 11:35 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 04/14] dt-bindings: mfd: ti,tps6594: Add TI TPS65224 PMIC Bhargav Raviprakash
2024-02-23 18:37 ` Conor Dooley
2024-02-23 9:36 ` [PATCH v2 05/14] mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C Bhargav Raviprakash
2024-02-26 11:40 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 06/14] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI Bhargav Raviprakash
2024-02-26 11:52 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 07/14] mfd: tps6594-core: Add TI TPS65224 PMIC core Bhargav Raviprakash
2024-02-26 12:17 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 08/14] misc: tps6594-pfsm: Add TI TPS65224 PMIC PFSM Bhargav Raviprakash
2024-02-26 12:43 ` Julien Panis
2024-03-07 9:13 ` Bhargav Raviprakash
2024-02-23 9:36 ` Bhargav Raviprakash [this message]
2024-02-26 12:56 ` [PATCH v2 09/14] misc: tps6594-esm: reversion check limited to TPS6594 family Julien Panis
2024-02-23 9:36 ` [PATCH v2 10/14] misc: tps6594-esm: use regmap_field Bhargav Raviprakash
2024-02-23 9:36 ` [PATCH v2 11/14] misc: tps6594-esm: Add TI TPS65224 PMIC ESM Bhargav Raviprakash
2024-02-23 9:36 ` [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators Bhargav Raviprakash
2024-02-29 13:58 ` Mark Brown
2024-03-07 9:15 ` Bhargav Raviprakash
2024-02-29 14:42 ` Esteban Blanc
2024-02-29 14:49 ` Mark Brown
2024-03-07 9:18 ` Bhargav Raviprakash
2024-03-07 9:17 ` Bhargav Raviprakash
2024-02-23 9:37 ` [PATCH v2 13/14] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO Bhargav Raviprakash
2024-02-29 13:24 ` Linus Walleij
2024-03-07 9:19 ` Bhargav Raviprakash
2024-03-07 9:36 ` Julien Panis
2024-02-29 13:56 ` Esteban Blanc
2024-02-23 9:37 ` [PATCH v2 14/14] arch: arm64: dts: ti: k3-am62p5-sk: Add TPS65224 PMIC support in AM62P dts Bhargav Raviprakash
2024-02-29 17:49 ` [PATCH v2 00/14] Add support for TI TPS65224 PMIC Lee Jones
2024-03-07 9:47 ` Bhargav Raviprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223093701.66034-10-bhargav.r@ltts.com \
--to=bhargav.r@ltts.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jpanis@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.nirmaladevi@ltts.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).