From: Lee Jones <lee@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Stephen Boyd <swboyd@chromium.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
Douglas Anderson <dianders@chromium.org>,
Pin-yen Lin <treapking@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 1/2] dt-bindings: cros-ec: Add properties for GPIO controller
Date: Fri, 23 Feb 2024 10:20:39 +0000 [thread overview]
Message-ID: <20240223102039.GK10170@google.com> (raw)
In-Reply-To: <CAMRc=Mft4R83NSknze0BMMvJd7Yz3yNGqaBSRVBePgh_S3QU1g@mail.gmail.com>
On Tue, 20 Feb 2024, Bartosz Golaszewski wrote:
> On Mon, Feb 19, 2024 at 9:23 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > The ChromeOS embedded controller (EC) supports setting the state of
> > GPIOs when the system is unlocked, and getting the state of GPIOs in all
> > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO
> > expander. Add the #gpio-cells and gpio-controller properties to the
> > cros-ec binding so that other devices described in DT can get the GPIOs
> > on the EC.
> >
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: Lee Jones <lee@kernel.org>
> > Cc: Benson Leung <bleung@chromium.org>
> > Cc: Guenter Roeck <groeck@chromium.org>
> > Cc: <devicetree@vger.kernel.org>
> > Cc: <chrome-platform@lists.linux.dev>
> > Cc: Pin-yen Lin <treapking@chromium.org>
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > ---
> > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > index e1ca4f297c6d..aac8819bd00b 100644
> > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > @@ -93,6 +93,11 @@ properties:
> > '#size-cells':
> > const: 0
> >
> > + '#gpio-cells':
> > + const: 2
> > +
> > + gpio-controller: true
> > +
> > typec:
> > $ref: /schemas/chrome/google,cros-ec-typec.yaml#
> >
> > @@ -275,6 +280,8 @@ examples:
> > interrupts = <99 0>;
> > interrupt-parent = <&gpio7>;
> > spi-max-frequency = <5000000>;
> > + #gpio-cells = <2>;
> > + gpio-controller;
> >
> > proximity {
> > compatible = "google,cros-ec-mkbp-proximity";
> > --
> > https://chromeos.dev
> >
>
> Applied, thanks!
Why are you applying this MFD patch?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-02-23 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 20:23 [PATCH 0/2] mfd: cros_ec_dev: Add gpio device and DT binding Stephen Boyd
2024-02-19 20:23 ` [PATCH 1/2] dt-bindings: cros-ec: Add properties for GPIO controller Stephen Boyd
2024-02-20 8:30 ` Krzysztof Kozlowski
2024-02-20 11:46 ` Bartosz Golaszewski
2024-02-23 10:20 ` Lee Jones [this message]
2024-02-19 20:23 ` [PATCH 2/2] mfd: cros_ec_dev: Add gpio device if feature present on EC Stephen Boyd
2024-02-23 17:08 ` [PATCH 0/2] mfd: cros_ec_dev: Add gpio device and DT binding Lee Jones
2024-03-25 1:54 ` patchwork-bot+chrome-platform
2024-03-25 2:13 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223102039.GK10170@google.com \
--to=lee@kernel.org \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).