From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Jérémie Dautheribes" <jeremie.dautheribes@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Andrew Davis" <afd@ti.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Yen-Mei Goh" <yen-mei.goh@keysight.com>
Subject: Re: [PATCH net-next 2/3] net: phy: dp83826: Add support for phy-mode configuration
Date: Fri, 23 Feb 2024 12:16:22 +0100 [thread overview]
Message-ID: <20240223121622.6bd9e3b1@device-28.home> (raw)
In-Reply-To: <20240222103117.526955-3-jeremie.dautheribes@bootlin.com>
Hello Jérémie,
On Thu, 22 Feb 2024 11:31:16 +0100
Jérémie Dautheribes <jeremie.dautheribes@bootlin.com> wrote:
> The TI DP83826 PHY can operate in either MII mode or RMII mode.
> By default, it is configured by straps.
> It can also be configured by writing to the bit 5 of register 0x17 - RMII
> and Status Register (RCSR).
>
> When phydev->interface is rmii, rmii mode must be enabled, otherwise
> mii mode must be set.
> This prevents misconfiguration of hw straps.
>
> Signed-off-by: Jérémie Dautheribes <jeremie.dautheribes@bootlin.com>
This looks good to me,
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
next prev parent reply other threads:[~2024-02-23 11:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 10:31 [PATCH net-next 0/3] Add support for TI DP83826 configuration Jérémie Dautheribes
2024-02-22 10:31 ` [PATCH net-next 1/3] dt-bindings: net: dp83822: support configuring RMII master/slave mode Jérémie Dautheribes
2024-02-22 15:09 ` Krzysztof Kozlowski
2024-02-26 15:28 ` Andrew Lunn
2024-02-29 20:46 ` Jérémie Dautheribes
2024-02-29 21:23 ` Andrew Lunn
2024-03-04 15:12 ` Jérémie Dautheribes
2024-03-04 16:06 ` Andrew Lunn
2024-03-04 16:31 ` Jérémie Dautheribes
2024-02-22 10:31 ` [PATCH net-next 2/3] net: phy: dp83826: Add support for phy-mode configuration Jérémie Dautheribes
2024-02-23 11:16 ` Maxime Chevallier [this message]
2024-02-26 15:34 ` Andrew Lunn
2024-02-22 10:31 ` [PATCH net-next 3/3] net: phy: dp83826: support configuring RMII master/slave operation mode Jérémie Dautheribes
2024-02-26 11:40 ` [PATCH net-next 0/3] Add support for TI DP83826 configuration patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223121622.6bd9e3b1@device-28.home \
--to=maxime.chevallier@bootlin.com \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jeremie.dautheribes@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yen-mei.goh@keysight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).