From: Dhruva Gole <d-gole@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Apurva Nandan" <a-nandan@ti.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
Nishanth <nm@ti.com>, Vignesh <vigneshr@ti.com>
Subject: Re: [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and system-wide suspend
Date: Mon, 26 Feb 2024 17:48:03 +0530 [thread overview]
Message-ID: <20240226121803.5a7r5wkpbbowcxgx@dhruva> (raw)
In-Reply-To: <170862920925.104158.14642580909914879148.b4-ty@kernel.org>
Hi Mark, Theo,
+ Nishanth, Vignesh (maintainers of TI K3)
On Feb 22, 2024 at 19:13:29 +0000, Mark Brown wrote:
> On Thu, 22 Feb 2024 11:12:28 +0100, Théo Lebrun wrote:
> > This fixes runtime PM and system-wide suspend for the cadence-qspi
> > driver. Seeing how runtime PM and autosuspend are enabled by default, I
> > believe this affects all users of the driver.
> >
> > This series has been tested on both Mobileye EyeQ5 hardware and the TI
> > J7200 EVM board, under s2idle.
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
>
> Thanks!
>
> [1/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks
> commit: 32ce3bb57b6b402de2aec1012511e7ac4e7449dc
> [2/4] spi: cadence-qspi: remove system-wide suspend helper calls from runtime PM hooks
> commit: 959043afe53ae80633e810416cee6076da6e91c6
> [3/4] spi: cadence-qspi: put runtime in runtime PM hooks names
> commit: 4efa1250b59ebf47ce64a7b6b7c3e2e0a2a9d35a
> [4/4] spi: cadence-qspi: add system-wide suspend and resume callbacks
> commit: 078d62de433b4f4556bb676e5dd670f0d4103376
It seems like between 6.8.0-rc5-next-20240220 and
6.8.0-rc5-next-20240222 some of TI K3 platform boot have been broken.
It particularly seemed related to these patches because we can see
cqspi_probe in the call trace and also cqspi_suspend toward the top.
See logs for kernel crash in [0] and working in [1]
[0] https://gist.github.com/DhruvaG2000/ed997452b41d6e5301598225fc579800
[1] https://gist.github.com/DhruvaG2000/d4e73111aeafaca555ba2d5208deb6dd
--
Best regards,
Dhruva Gole <d-gole@ti.com>
next prev parent reply other threads:[~2024-02-26 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 10:12 [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and system-wide suspend Théo Lebrun
2024-02-22 10:12 ` [PATCH v4 1/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks Théo Lebrun
2024-02-22 10:12 ` [PATCH v4 2/4] spi: cadence-qspi: remove system-wide suspend helper calls from " Théo Lebrun
2024-02-22 10:12 ` [PATCH v4 3/4] spi: cadence-qspi: put runtime in runtime PM hooks names Théo Lebrun
2024-02-22 10:22 ` Dhruva Gole
2024-02-22 10:12 ` [PATCH v4 4/4] spi: cadence-qspi: add system-wide suspend and resume callbacks Théo Lebrun
2024-02-22 19:13 ` [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and system-wide suspend Mark Brown
2024-02-26 12:18 ` Dhruva Gole [this message]
2024-02-26 13:27 ` Mark Brown
2024-02-26 13:40 ` Mark Brown
2024-02-26 13:42 ` Théo Lebrun
2024-02-27 5:03 ` Dhruva Gole
2024-02-26 13:36 ` Théo Lebrun
2024-02-27 12:00 ` Dhruva Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226121803.5a7r5wkpbbowcxgx@dhruva \
--to=d-gole@ti.com \
--cc=a-nandan@ti.com \
--cc=broonie@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).